Opened 8 years ago
Closed 8 years ago
#51610 closed submission (fixed)
xdrfile @ 1.1.4 new port
Reported by: | GiovanniBussi (Giovanni) | Owned by: | macports-tickets@… |
---|---|---|---|
Priority: | Normal | Milestone: | |
Component: | ports | Version: | 2.3.4 |
Keywords: | Cc: | GiovanniBussi (Giovanni) | |
Port: | xdrfile |
Description
I would like to contribute a port for this BSD library: http://www.gromacs.org/Developer_Zone/Programming_Guide/XTC_Library
Attachments (2)
Change History (6)
Changed 8 years ago by GiovanniBussi (Giovanni)
comment:1 Changed 8 years ago by mf2k (Frank Schima)
comment:2 Changed 8 years ago by GiovanniBussi (Giovanni)
Thanks for the hints!
- I removed
distfiles
as suggested. - I added
openmaintainer
as suggested. - I replaced
configure.args
withconfigure.args-append
to avoid overriding other flags.
Actually, I also realised that the port compiles properly with +universal even without including the muniversal portgroup. I thus removed it.
About a non-FTP master_sites
location, I am not aware of it.
I hope the revised port can be considered for inclusion.
Thanks again!
Giovanni
comment:4 Changed 8 years ago by raimue (Rainer Müller)
Resolution: | → fixed |
---|---|
Status: | new → closed |
Thank you for the submission. Committed in r149826.
Note: See
TracTickets for help on using
tickets.
Comments:
distfiles
directly, it is best practice to set ${distname} and ${extract.suffix} separately. In fact, I believe thedistfiles
line in the Portfile is the default value and should simply be removed.openmaintainer
since you are not a committer.+universal
? You are overriding theconfigure.args
which are set by the muniversal PortGroup.