Opened 8 years ago

Closed 8 years ago

#51610 closed submission (fixed)

xdrfile @ 1.1.4 new port

Reported by: GiovanniBussi (Giovanni) Owned by: macports-tickets@…
Priority: Normal Milestone:
Component: ports Version: 2.3.4
Keywords: Cc: GiovanniBussi (Giovanni)
Port: xdrfile

Description

I would like to contribute a port for this BSD library: ​http://www.gromacs.org/Developer_Zone/Programming_Guide/XTC_Library

Attachments (2)

Portfile​ (1.2 KB) - added by GiovanniBussi (Giovanni) 8 years ago.
Portfile.2​ (1.1 KB) - added by GiovanniBussi (Giovanni) 8 years ago.
Updated portfile

Download all attachments as: .zip

Change History (6)

Changed 8 years ago by GiovanniBussi (Giovanni)

Attachment: Portfile​ added

comment:1 Changed 8 years ago by mf2k (Frank Schima)

Comments:

  • In general, we do not set distfiles directly, it is best practice to set ${distname} and ${extract.suffix} separately.
  • Considering adding openmaintainer since you are not a committer.
  • Is there a non-FTP master_sites location?
  • Have you tested this when building +universal? You are overriding the configure.args which are set by the muniversal PortGroup​.
Version 0, edited 8 years ago by mf2k (Frank Schima) (next)

Changed 8 years ago by GiovanniBussi (Giovanni)

Attachment: Portfile.2​ added

Updated portfile

comment:2 Changed 8 years ago by GiovanniBussi (Giovanni)

Thanks for the hints!

  • I removed distfiles as suggested.
  • I added openmaintainer as suggested.
  • I replaced configure.args with configure.args-append to avoid overriding other flags.

Actually, I also realised that the port compiles properly with +universal even without including the muniversal portgroup. I thus removed it.

About a non-FTP master_sites location, I am not aware of it.

I hope the revised port can be considered for inclusion.

Thanks again!

Giovanni

comment:3 Changed 8 years ago by GiovanniBussi (Giovanni)

Cc: giovanni.bussi@… added

Cc Me!

comment:4 Changed 8 years ago by raimue (Rainer Müller)

Resolution: → fixed
Status: new → closed

Thank you for the submission. Committed in r149826.

Note: See TracTickets for help on using tickets.