gnupg21 @2.1.12_0: enables TLS support opportunistically

[larryv (Lawrence Velázquez)]

Without gnutls installed:

:info:configure checking for ntbtls-config... no
:info:configure checking for NTBTLS - version >= 0.1.0... no
:info:configure checking for LIBGNUTLS... no
:info:configure configure: WARNING:
:info:configure ***
:info:configure *** Building without NTBTLS and GNUTLS - no TLS access to keyservers.
:info:configure ***
:info:configure *** No package 'gnutls' found

:info:configure         GnuPG v2.1.12 has been configured as follows:

:info:configure         TLS support:         no

With gnutls installed:

:info:configure checking for ntbtls-config... no
:info:configure checking for NTBTLS - version >= 0.1.0... no
:info:configure checking for LIBGNUTLS... yes

:info:configure         GnuPG v2.1.12 has been configured as follows:

:info:configure         TLS support:         gnutls

I don’t know how you want to deal with this. I think it would be best to add the dependency on gnutls so that TLS is always available, but that means requiring curl +gnutls. At a minimum, the port should configure with --disable-gnutls to prevent the opportunistic behavior.

[roederja]

Hi, thanks for finding this. I will add the GNUTLS dependency.

[larryv (Lawrence Velázquez)]

Enabling GnuTLS support might not actually not require curl +gnutls. I don’t know whether GnuPG cares what curl is using. Hopefully it doesn’t care at all, and we can avoid variant-dependency shenanigans.

[larryv (Lawrence Velázquez)]

At a glance, it looks like the 2.1 series hasn’t actually used cURL in a while—the configure script doesn’t even check for it. Ideally, you can simply remove the dependency on curl and add one for gnutls when you push the 2.1.13 update (which dropped a couple of hours ago).

[roederja]

Fixed in r149405. Thanks

[larryv (Lawrence Velázquez)]

Thank you!