Opened 8 years ago

Closed 8 years ago

#51713 closed defect (fixed)

devel/ninja update and build fix

Reported by: slewsys (Andrew L. Moore) Owned by: macports-tickets@…
Priority: Normal Milestone:
Component: ports Version: 2.3.4
Keywords: haspatch Cc:
Port: ninja

Description

devel/ninja fails to build under OS X 10.11.5/Xcode 7.3.1. At some point during bootstrap, the file build.ninja is be appended to itself. Although bootstrap succeeds, subsequent rebuild with ./ninja fails since rule cxx, et al. occur twice.

Manually invoking python configure.py --bootstrap completes without errors, so it appears to be an interaction between port and python (either /usr/bin/python or MacPorts python2.7).

Unable to replicate issue under OS X 10.9.5/Xcode 6.2.

Attached is a workaround (works on both systems) and update to ninja 1.7.1. configure.py is patched to run bootstrap only. It's invoked at the configure stage. After bootstrap, the script configure then edits build.ninja to remove any redundancy.

Ninja does not appear to have an active maintainer.

Attachments (3)

Portfile.diff​ (1.7 KB) - added by slewsys (Andrew L. Moore) 8 years ago.
Portfile diff
configure.py-bootstrap-only.diff​ (1.6 KB) - added by slewsys (Andrew L. Moore) 8 years ago.
Patch configure.py to only bootstrap.
configure.diff​ (281 bytes) - added by slewsys (Andrew L. Moore) 8 years ago.
configure script - bootstraps and then edits build.ninja

Download all attachments as: .zip

Change History (8)

Changed 8 years ago by slewsys (Andrew L. Moore)

Attachment: Portfile.diff​ added

Portfile diff

Changed 8 years ago by slewsys (Andrew L. Moore)

Attachment: configure.py-bootstrap-only.diff​ added

Patch configure.py to only bootstrap.

Changed 8 years ago by slewsys (Andrew L. Moore)

Attachment: configure.diff​ added

configure script - bootstraps and then edits build.ninja

comment:1 Changed 8 years ago by ryandesign (Ryan Carsten Schmidt)

Keywords: haspatch added
Owner: changed from macports-tickets@… to 521E328E-2A13-4749-826A-E4EF4F22A0F1@…
Port: ninja added

comment:2 Changed 8 years ago by mf2k (Frank Schima)

Owner: changed from 521E328E-2A13-4749-826A-E4EF4F22A0F1@… to macports-tickets@…

This port no longer has a maintainer. See #51714.

comment:3 Changed 8 years ago by mf2k (Frank Schima)

Thank you! r149580. Please consider being the maintainer of this port.

I made the following minor changes:

  • Renamed all patchfiles to conform to Macports patchfile naming convention. Thus appeasing lint.
  • As a best practice, changed depends_build to depends_build-append due to the use of the github Portgroup so as to not overwrite dependencies.

comment:4 Changed 8 years ago by mf2k (Frank Schima)

Missing patches added in r149587.

comment:5 Changed 8 years ago by mf2k (Frank Schima)

Resolution: → fixed
Status: new → closed
Note: See TracTickets for help on using tickets.