Opened 8 years ago

Closed 8 years ago

Last modified 8 years ago

#51761 closed enhancement (fixed)

Processing: new maintainer and patch

Reported by: numeratus Owned by: macports-tickets@…
Priority: Not set Milestone:
Component: ports Version: 2.3.4
Keywords: haspatch Cc: kurthindenburg (Kurt Hindenburg)
Port: processing

Description

processing port referring to old Google code repo. It's now on git.

Attachments (2)

change-processing-maintainer.diff (2.0 KB) - added by numeratus 8 years ago.
change-processing-maintainder.diff (1.2 KB) - added by numeratus 8 years ago.
Upgrade to 3.2.1

Download all attachments as: .zip

Change History (10)

comment:1 Changed 8 years ago by mf2k (Frank Schima)

Thanks. Comments:

  • Do not modify the # $Id: line. It may mean you have edited on old version of the Portfile.
  • Use the Github portgroup. This will simplify the portfile and be more reliable.
  • You have changed the license from BSD to GPL. What specific version of the GPL is it licensed under?

comment:2 Changed 8 years ago by ryandesign (Ryan Carsten Schmidt)

Using the github portgroup will also help you ensure the port downloads the version of the source code that it claims to offer. (The patch you submitted here so far always downloads the latest version of the code, which we don't allow.)

comment:3 Changed 8 years ago by numeratus

Thanks for the detailed feedback. I've enclosed an updated diff file.

comment:4 Changed 8 years ago by ryandesign (Ryan Carsten Schmidt)

Use of the github portgroup is meant to simplify fetching files from GitHub. You're not meant to have to set github.tag_prefix, github.master_sites, use_zip, distname, distfiles; the defaults of the portgroup should be sufficient. All you should have to set is

github.setup processing processing 3.1.1 processing-0250-

Changed 8 years ago by numeratus

comment:5 Changed 8 years ago by numeratus

My apologies ryandesign@…, I thought I had exhausted that option (hence my foray into custom paths), but a quick test proved me wrong.

The diff file has been updated with only the github.setup command added and every other option removed.

comment:6 Changed 8 years ago by kurthindenburg (Kurt Hindenburg)

Cc: khindenburg@… added
Resolution: fixed
Status: newclosed

I went ahead and committed your patch - I don't have the correct java installed to verify it installs. Also, I'm not positive the livecheck is correct but that can be fixed later.

r152944

Changed 8 years ago by numeratus

Upgrade to 3.2.1

comment:7 Changed 8 years ago by ryandesign (Ryan Carsten Schmidt)

This ticket superseded #49762.

The update to 3.2.1 is handled in #52298.

comment:8 Changed 8 years ago by ryandesign (Ryan Carsten Schmidt)

Cc: kurthindenburg added; khindenburg@… removed
Note: See TracTickets for help on using tickets.