Opened 8 years ago

Closed 8 years ago

#51833 closed update (fixed)

gnucash @2.6.13 update to new version

Reported by: david.spreen+macports@… Owned by: drkp (Dan Ports)
Priority: Normal Milestone:
Component: ports Version:
Keywords: haspatch Cc:
Port: gnucash

Description

There's a new version of gnucash (2.6.13). Portfile patch is attached. Note that the gnucash maintainer released a special tarball for OSX gnucash-2.6.13b.tar.bz2 but the source directory is still named 2.6.13. setting distfiles manually ensures working build.

Attachments (2)

gnucash.diff​ (1.0 KB) - added by david.spreen+macports@… 8 years ago.
Portfile patch
gnucash.2.diff​ (972 bytes) - added by david.spreen+macports@… 8 years ago.
Updated Portfile patch.

Download all attachments as: .zip

Change History (7)

Changed 8 years ago by david.spreen+macports@…

Attachment: gnucash.diff​ added

Portfile patch

comment:1 Changed 8 years ago by mf2k (Frank Schima)

Cc: dports@… openmaintainer@… removed
Owner: changed from macports-tickets@… to dports@…
Version: 2.3.4

Thanks. Please do not Cc openmaintainer@… because it is not a valid email address.

Comments:

  • The revision line should be deleted because it starts at 0 when increasing the version and that is the default value.
  • We do not set distfiles directly, it is best practice to set ${distname} and ${extract.suffix} separately. In this case, only the distname needs to be set.

comment:2 in reply to:  1 Changed 8 years ago by david.spreen+macports@…

Replying to mf2k@…:

  • We do not set distfiles directly, it is best practice to set ${distname} and ${extract.suffix} separately. In this case, only the distname needs to be set.

Thanks for your comments. If I set ${distname} instead of distfiles, the build fails because the sourcedir inside the tarball lacks the "b." I assume this means I should also be setting ${worksourcedir} separately?

Changed 8 years ago by david.spreen+macports@…

Attachment: gnucash.2.diff​ added

Updated Portfile patch.

comment:3 Changed 8 years ago by mf2k (Frank Schima)

Correct.

comment:4 Changed 8 years ago by mf2k (Frank Schima)

Keywords: haspatch added

comment:5 Changed 8 years ago by drkp (Dan Ports)

Resolution: → fixed
Status: new → closed

Thanks, applied in r158044.

Note: See TracTickets for help on using tickets.