Opened 8 years ago

Closed 8 years ago

#52010 closed enhancement (fixed)

qt5-mysql-plugin for MariaDB

Reported by: ctreleaven (Craig Treleaven) Owned by: MarcusCalhoun-Lopez (Marcus Calhoun-Lopez)
Priority: Normal Milestone:
Component: ports Version: 2.3.4
Keywords: Cc:
Port: qt5-mysql-plugin

Description

Does Qt5 support mariadb (5.5) or anything other than mysql 5.6?

The new version of MythTV has adopted Qt5. Previously, my port used qt4-mac-mariadb-plugin to access MariaDB 5.5 as the backend database. I'd like to stay with that so users don't have to do a tricky backup-from-one-version-and-restore-to-another when upgrading.

There does not seem to be a Qt5 equivalent currently. Is this a possible enhancement?

Change History (3)

comment:1 Changed 8 years ago by larryv (Lawrence Velázquez)

Owner: changed from mcalhoun to mcalhoun@…

comment:2 Changed 8 years ago by ctreleaven (Craig Treleaven)

OK, it is a trivial patch to get it working with MariaDB:

$ diff -u /opt/dvr/var/macports/sources/rsync.macports.org/release/tarballs/ports/aqua/qt5/Portfile Portfile
--- /opt/dvr/var/macports/sources/rsync.macports.org/release/tarballs/ports/aqua/qt5/Portfile	2016-06-15 11:01:22.000000000 -0400
+++ Portfile	2016-08-13 14:33:25.000000000 -0400
@@ -450,6 +450,13 @@
     }
     {mysql MySQL} {
         {
+            "mariadb55"
+            "port:mariadb"
+            "${prefix}/include/mariadb/mysql"
+            "-L${prefix}/lib/mariadb/mysql -lmysqlclient_r"
+            ""
+        }
+        {
             "mysql56"
             "port:mysql56"
             "${prefix}/include/mysql56/mysql"

BUT, as patched, the mariadb55 variant becomes the default variant (since it is first) to a port named "qt5-mysql-plugin". Clearly that is more than a little odd--one would expect mysql56 or mysql57 to be the default. OTOH, AFAICT, I'm the first one to be relying on this port as a dependency. If my mariadb55 variant is the default, it will be pre-compiled, etc.

OTOH, I think it would be preferable if the qt5-xxx-plugin's did not use variants--use more subports, instead. So there would be qt5-mysql56-plugin, qt5-mysql57-plugin, qt5-mariadb55-plugin, etc. Restructuring that is beyond my pay grade.

I'd like to move ahead with this. If I don't hear anything shortly, I'm going to commit the simple patch. It can always be changed or reverted.

comment:3 Changed 8 years ago by ctreleaven (Craig Treleaven)

Resolution: fixed
Status: newclosed

Patch amended to increment revision and committed in r151636.

Note: See TracTickets for help on using tickets.