perl5.24: build error on Sierra (use of undeclared identifier 'darwin_time_mutex')

[fritz.ganter@…]

Hi! I get a build error on macOS Sierra: Processing of port perl5.24 failed The same error happens with perl 5.22.

HiRes.xs:945:15: error: use of undeclared identifier 'darwin_time_mutex'
  MUTEX_INIT(&darwin_time_mutex);
              ^
1 error generated.

Log attached. Thank you for your work!

[fritz.ganter@…]

Logfile

[mojca (Mojca Miklavec)]

There's also #51980, but that's a different one.

[mojca (Mojca Miklavec)]

See also ​https://github.com/Homebrew/homebrew-core/issues/1957, there might be the solution. I'll look at it, but I might be offline for two days.

[mojca (Mojca Miklavec)]

I committed r151547 and r151549. In case that this didn't solve the problem, please reopen the ticket. I'm just speculating that the patch helps based on comments and commits to HomeBrew.

[mojca (Mojca Miklavec)]

I also opened a ticket at ​https://rt.perl.org/Ticket/Display.html?id=128972

[platipodium (Carsten Lemmen)]

The patch does not work for me (this should be a new defect?)

:debug:patch Assembled command: 'cd "/opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_release_tarballs_ports_lang_perl5/perl5.22/work/perl-5.22.2" && /usr/bin/patch -p0' :debug:patch Executing command line: cd "/opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_release_tarballs_ports_lang_perl5/perl5.22/work/perl-5.22.2" && /usr/bin/patch -p0 < '/opt/local/var/macports/sources/rsync.macports.org/release/tarballs/ports/lang/perl5/files/5.22/patch-dist-Time-HiRes-HiRes.xs.diff' :info:patch can't find file to patch at input line 6

[fritz.ganter@…]

For me also. But 5.24 works now. Thanks.

[mojca (Mojca Miklavec)]

I'm sorry. I didn't test on 5.22 well enough and now reverted the patch in r151562.

What exactly is the problem with 5.22 now?

[fritz.ganter@…]

:info:build env MACOSX_DEPLOYMENT_TARGET=10.3 /usr/bin/clang -o libperl.dylib -L/opt/local/lib -Wl,-headerpad_max_install_names -arch x86_64 -fstack-protector-strong -dynamiclib -compatibility_version 5.22.0 -current_version 5.22 .2 -install_name /opt/local/lib/perl5/5.22/darwin-thread-multi-2level/CORE/libperl.dylib op.o perl.o gv.o toke.o perly.o pad.o regcomp.o dump.o

util.o mg.o reentr.o mro_core.o keywords.o hv.o av.o run.o pp_hot.o sv.o pp.o scope.o pp_ctl.o pp_sys.o doop.o doio.o regexec.o utf8.o taint.o deb.o universal.o glob

als.o perlio.o perlapi.o numeric.o mathoms.o locale.o pp_pack.o pp_sort.o caretx.o DynaLoader.o -lpthread -ldl -lm -lutil -lc :info:build ld: library not found for -lgcc_s.10.4 :info:build clang: error: linker command failed with exit code 1 (use -v to see invocation) :info:build make: * [libperl.dylib] Error 1

[fritz.ganter@…]

Logfile for 5.22

[fritz.ganter@…]

I attached the log file for 5.22, 5.24 now works for me.

[mojca (Mojca Miklavec)]

That's #51980.