libsodium @1.0.11: error: passing '__m128i' to parameter of incompatible type 'const __m128i *'

[ryandesign (Ryan Carsten Schmidt)]

libsodium @1.0.11 fails to build:

crypto_generichash/blake2/ref/blake2b-compress-avx2.c:38:5: error: passing '__m128i' to parameter of incompatible type 'const __m128i *'
    BLAKE2B_COMPRESS_V1(a, b, block, S->t[0], S->t[1], S->f[0], S->f[1]);
    ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

​https://build.macports.org/builders/ports-10.7_x86_64_legacy-builder/builds/2091

Maybe Lion's version of clang is too old and needs to be blacklisted.

[kencu (Ken)]

This seems to block the build of widelands and widelands-devel on 10.7 as well. I can build libsodium with macports-clang-3.7+ without any trouble. I don't have anything lower installed.

I guess libsodium built with whatever macos 10.8 provides... according to <​https://trac.macports.org/wiki/XcodeVersionInfo> that was last noted to be to following, which is what I assume the buildbots have installed:

Xcode 5.1.1

    Xcode: Build version 5B1008
    clang: Apple LLVM version 5.1 (clang-503.0.40) (based on LLVM 3.4svn) 

so blacklisting clang < 503 should do it, I think. For sure blacklisting clang < 700 would work, but that might trigger a lot of clang installs that are unnecessary.

[kencu (Ken)]

see also 54407 for what is likely a duplicate.

[kencu (Ken)]

I have submitted <​https://github.com/macports/macports-ports/pull/638> to fix this.

[kencu (Ken)]

In 25f1ff7840625d87aeabf3534b63b49b128d6d45/macports-ports:

libsodium: add cxx11 1.1 PortGroup

Fixes builds on older systems
Closes #52050
Closes ​https://github.com/macports/macports-ports/pull/638

No revbump since port either builds correctly or not at all