#52069 closed defect (fixed)
wxWidgets-3.0: is not building in 10.12 Sierra beta due to missing QuickTime.h
Reported by: | reactortrip@… | Owned by: | mojca (Mojca Miklavec) |
---|---|---|---|
Priority: | Normal | Milestone: | |
Component: | ports | Version: | |
Keywords: | sierra | Cc: | jyrkiwahlstedt, mkae (Marko Käning), herrbischoff (Marcel Bischoff) |
Port: | wxWidgets-3.0 wxPython-3.0 |
Description (last modified by mojca (Mojca Miklavec))
I am attempting to install HackRF/GNURadio, wxPython-3.0
is failing to build.
:info:build ../src/osx/core/bitmap.cpp:39:10: fatal error: 'QuickTime/QuickTime.h' file not found :info:build #include <QuickTime/QuickTime.h> :info:build ^
Upstream ticket: http://trac.wxwidgets.org/ticket/17639
Attachments (4)
Change History (21)
Changed 8 years ago by reactortrip@…
comment:1 Changed 8 years ago by mojca (Mojca Miklavec)
Cc: | mojca@… removed |
---|---|
Description: | modified (diff) |
Keywords: | sierra added |
Owner: | changed from macports-tickets@… to mojca@… |
Port: | wxWidgets-3.0 wxPython-3.0 added; wxpython-3.0 removed |
Summary: | wxpython-3.0 is not building in 10.12 Sierra beta → wxWidgets-3.0: is not building in 10.12 Sierra beta due to missing QuickTime.h |
Version: | 2.3.4 |
comment:2 Changed 8 years ago by mojca (Mojca Miklavec)
... and if that works, we should ask the upstream to backport the fix to the 3.0 and 3.1 branch.
Changed 8 years ago by reactortrip@…
Attachment: | main.2.log added |
---|
comment:3 Changed 8 years ago by reactortrip@…
Can you delete an attachment, think I grabbed the wrong main
Changed 8 years ago by reactortrip@…
Attachment: | main.3.log added |
---|
comment:4 Changed 8 years ago by reactortrip@…
main.3.log should be correct, wxWidget-3.0 still didn't build for me with those changes.
comment:5 Changed 8 years ago by mojca (Mojca Miklavec)
That's:
../src/osx/cocoa/mediactrl.mm:52:10: fatal error: 'QTKit/QTKit.h' file not found #include <QTKit/QTKit.h> ^
The master
branch can switch between the deprecated QtKit and AV Foundation, but that would require backporting quite a bit more code. As a temporary workaround maybe someting like --disable-mediactrl
in configure.flags
would help?
comment:7 Changed 8 years ago by mojca (Mojca Miklavec)
In graphics/wxWidgets-3.0/Portfile
try to apply the following patch (add that option to configure.flags
):
-
Portfile
117 117 --with-cocoa \ 118 118 --without-sdl \ 119 119 --enable-aui \ 120 --disable-mediactrl \ 120 121 --disable-sdltest \ 121 122 --enable-unicode \ 122 123 --enable-display \
comment:9 Changed 8 years ago by mojca (Mojca Miklavec)
I opened a new upstream ticket, but have to wait for moderation before they publish it. I guess we can disable mediactrl on 10.12 until someone needs it and comes up with a patch for it.
Changed 8 years ago by mojca (Mojca Miklavec)
Attachment: | wxWidgets-3.0-for-Sierra.diff added |
---|
Temporary workaround to allow building wxWidgets on Sierra
comment:10 Changed 8 years ago by mojca (Mojca Miklavec)
I attached the patch with a workaround. If someone on Sierra can double-check that the patch is ok (and that you can build both wxWidgets-3.0 and wxPython-3.0), I'll commit it.
reactortrip: I'm unable to delete attachments (maybe the admin can), but a trick that works is to upload another file with the same name and tick the checkbox to replace the file. Next time you could rename main.log
to main.log.2
and upload that one. Or you could upload an empty file now. But at this moment it doesn't make any sense to worry about faulty uploads unless the file contains some sensitive information.
comment:11 Changed 8 years ago by mojca (Mojca Miklavec)
Description: | modified (diff) |
---|
I added a link to the upstream ticket.
comment:13 Changed 8 years ago by mojca (Mojca Miklavec)
Once again, I would be grateful for some testers of the attached patch before I commit it.
I would also like to ask for another check if there is some brave tester around. Please try to copy src/osx/cocoa/mediactrl.mm
(and mediactrl.h
) from the master branch and add -DwxOSX_USE_QTKIT=0
to configure.cflags-append
(I think). Make sure to remove --disable-mediactrl
. I would like to have mediactrl eventually working on 10.12.
comment:16 Changed 8 years ago by mojca (Mojca Miklavec)
Resolution: | → fixed |
---|---|
Status: | new → closed |
comment:17 Changed 8 years ago by mojca (Mojca Miklavec)
See also #52951 which is basically "a duplicate" of this bug. Changes have recently been backported to the 3.0 branch:
I didn't install Sierra yet.
Link to an upstream commit in master:
plus a reference in HomeBrew fighting with the same problem:
I guess we could test the upstream commit and apply it.