zstd @1.0.0: cp: illegal option -- a

[ryandesign (Ryan Carsten Schmidt)]

zstd @1.0.0 fails to build on Leopard:

make: Entering directory `/opt/local/var/macports/build/_opt_bblocal_var_buildworker_ports_build_dports_archivers_zstd/zstd/work/zstd-1.0.0'
/usr/bin/make -C lib install
make[1]: Entering directory `/opt/local/var/macports/build/_opt_bblocal_var_buildworker_ports_build_dports_archivers_zstd/zstd/work/zstd-1.0.0/lib'
compiling static library
compiling dynamic library 1.0.0
creating versioned links
creating pkgconfig
cp: illegal option -- a
usage: cp [-R [-H | -L | -P]] [-fi | -n] [-pvX] source_file target_file
       cp [-R [-H | -L | -P]] [-fi | -n] [-pvX] source_file ... target_directory
make[1]: *** [install] Error 64
make[1]: Leaving directory `/opt/local/var/macports/build/_opt_bblocal_var_buildworker_ports_build_dports_archivers_zstd/zstd/work/zstd-1.0.0/lib'
make: *** [install] Error 2
make: Leaving directory `/opt/local/var/macports/build/_opt_bblocal_var_buildworker_ports_build_dports_archivers_zstd/zstd/work/zstd-1.0.0'
Command failed:  cd "/opt/local/var/macports/build/_opt_bblocal_var_buildworker_ports_build_dports_archivers_zstd/zstd/work/zstd-1.0.0" && /usr/bin/make -w install DESTDIR=/opt/local/var/macports/build/_opt_bblocal_var_buildworker_ports_build_dports_archivers_zstd/zstd/work/destroot 
Exit code: 2

The cp program on Leopard and earlier does not understand the -a flag. Use -pPR instead, which is equivalent.

[seanfarley (Sean Farley)]

Is that something that could go upstream? Or is this just a Leopard patch?

[seanfarley (Sean Farley)]

I don't have a leopard machine to test this on but I tried to fix it in r152241 and r152242. For errors like this, please feel free to fix.

[larryv (Lawrence Velázquez)]

The change should work and can be applied on all systems.

[seanfarley (Sean Farley)]

I wasn't able to use it for 10.11:

cp: the -H, -L, and -P options may not be specified with the -r option.

:-(

[larryv (Lawrence Velázquez)]

That should be -R instead of -r (which is an obsolete, worse version of -R).

[seanfarley (Sean Farley)]

Thanks @larryv. I cannot read. Fixed (finally) in r152244.

[ryandesign (Ryan Carsten Schmidt)]

I've been monitoring the build system more closely, since we don't have email notifications right now, and reporting problems as I see them, but I don't have time to fix every problem myself. Thanks for fixing it. Yes, it should be reported to the developers for them to fix in their sources.

[seanfarley (Sean Farley)]

Oh, sure, I don't mean fix all the errors you see :-) I just meant, if anyone else saw a problem like this, they don't need my permission to push a change. Anyway, thanks again for the report and fix!