10.12 SDK breaks qt5-qtconnectivity build

[howarth.at.macports@…]

The 10.12 SDK breaks the build of qt5-qtconnectivity under Xcode 8 on 10.11 with the error...

/usr/bin/clang++ -c -pipe -stdlib=libc++ -stdlib=libc++ -O2 -std=c++1z -isysroot /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.12.sdk -mmacosx-version-min=10.11 -fvisibility=hidden -fvisibility-inlines-hidden -fno-exceptions -Wall -W -fPIC -DQT_NO_MTDEV -DQT_NO_LIBUDEV -DQT_NO_EVDEV -DQT_NO_TSLIB -DQT_NO_LIBINPUT -DQT_OSX_BLUETOOTH -DQT_BUILD_BLUETOOTH_LIB -DQT_BUILDING_QT -DQT_NO_CAST_TO_ASCII -DQT_ASCII_CAST_WARNINGS -DQT_MOC_COMPAT -DQT_USE_QSTRINGBUILDER -DQT_DEPRECATED_WARNINGS -DQT_DISABLE_DEPRECATED_BEFORE=0x050000 -DQT_NO_EXCEPTIONS -D_LARGEFILE64_SOURCE -D_LARGEFILE_SOURCE -DQT_NO_DEBUG -DQT_CORE_LIB -DQT_CONCURRENT_LIB -DQT_CORE_LIB -I. -I../../include -I../../include/QtBluetooth -I../../include/QtBluetooth/5.6.1 -I../../include/QtBluetooth/5.6.1/QtBluetooth -I/opt/local/libexec/qt5/lib/QtCore.framework/Headers -I/opt/local/libexec/qt5/lib/QtConcurrent.framework/Headers -I.moc -I/opt/local/libexec/qt5/mkspecs/macx-clang -F/opt/local/libexec/qt5/lib -o .obj/osxbtutility.o osx/osxbtutility.mm
osx/osxbtutility.mm:171:14: error: property 'data' cannot be found in forward class object 'CBUUID'
    if (uuid.data.length == 2) {
        ~~~~ ^
osx/osxbtutility_p.h:58:8: note: forward declaration of class here
@class CBUUID;
       ^
osx/osxbtutility.mm:174:66: error: property 'data' cannot be found in forward class object 'CBUUID'
        const uchar *const src = static_cast<const uchar *>(uuid.data.bytes);
                                                            ~~~~ ^
osx/osxbtutility_p.h:58:8: note: forward declaration of class here
@class CBUUID;
       ^
osx/osxbtutility.mm:176:21: error: property 'data' cannot be found in forward class object 'CBUUID'
    } else if (uuid.data.length == 16) {
               ~~~~ ^
osx/osxbtutility_p.h:58:8: note: forward declaration of class here
@class CBUUID;
       ^
osx/osxbtutility.mm:178:71: error: property 'data' cannot be found in forward class object 'CBUUID'
        const quint8 *const source = static_cast<const quint8 *>(uuid.data.bytes);
                                                                 ~~~~ ^
osx/osxbtutility_p.h:58:8: note: forward declaration of class here
@class CBUUID;
       ^
osx/osxbtutility.mm:184:36: error: property 'data' cannot be found in forward class object 'CBUUID'
                           << uuid.data.length << " bytes length";
                              ~~~~ ^
osx/osxbtutility_p.h:58:8: note: forward declaration of class here
@class CBUUID;
       ^
osx/osxbtutility.mm:188:14: error: property 'data' cannot be found in forward class object 'CBUUID'
    if (uuid.data.length != 16) // TODO: warning?
        ~~~~ ^
osx/osxbtutility_p.h:58:8: note: forward declaration of class here
@class CBUUID;
       ^
osx/osxbtutility.mm:213:41: warning: receiver 'CBUUID' is a forward class and corresponding @interface may not exist [-Wreceiver-forward-class]
    ObjCStrongReference<CBUUID> cbUuid([CBUUID UUIDWithCFUUID:cfUuid], true); //true == retain.
                                        ^~~~~~
osx/osxbtutility_p.h:58:8: note: forward declaration of class here
@class CBUUID;
       ^
osx/osxbtutility.mm:213:48: warning: class method '+UUIDWithCFUUID:' not found (return type defaults to 'id') [-Wobjc-method-access]
    ObjCStrongReference<CBUUID> cbUuid([CBUUID UUIDWithCFUUID:cfUuid], true); //true == retain.
                                               ^~~~~~~~~~~~~~
2 warnings and 6 errors generated.
make: *** [.obj/osxbtutility.o] Error 1

Substituting the 10.11 SDK from Xcode 7.3.1 eliminates the compile failure.

[ctreleaven (Craig Treleaven)]

Cc Me!

[astroboylrx (Rixin Li)]

Cc Me!

[larsvancasteren@…]

Cc Me!

[wybosys@…]

Cc Me!

[me@…]

Cc Me!

[3add3287 (3add3287)]

Cc Me!

[mamoll (Mark Moll)]

Cc Me!

[sebastian@…]

Cc Me!

[vs-never@…]

Cc Me!

[RJVB (René Bertin)]

I'm pretty sure I've stumbled across fragments of instructions on how to install the 10.11 SDK in Xcode 8 in recent google searches. That could at least provide a temporary workaround until a better fix is found.

Edit: it's been my experience with Qt5 that it is a good idea in general to use the platform-specific SDK (or at the very least, specify the SDK to be used explicitly rather than letting the build system and/or compiler figure out which one to use).

[mkae (Marko Käning)]

Cc Me!

[axet (Alexey Kuznetsov)]

Cc Me!

[RJVB (René Bertin)]

A patch has been proposed upstream: ​https://codereview.qt-project.org/#/c/172619/; I'll attach it to this ticket (it's already included in my port:qt5-kde but only tested on 10.9)

[mkae (Marko Käning)]

The patch fixed building qt5-kde on El Capitan 10.11.6 - containing only the 10.12 SDK.

Thanks, René, for investigating this!

[mamoll (Mark Moll)]

The patch fixes the build on MacOS Sierra 10.12 with 10.12 SDK.

[skymoo (Adam Mercer)]

Cc Me!

[raimue (Rainer Müller)]

Cc Me!

[raimue (Rainer Müller)]

Thank you! Patch added to Portfile in r153655.