octave-4.0.3 fails to build with XCode 8 / OSX Sierra

[dimkab]

Log attached. The first error seems to be

:info:build In file included from array/Array-ch.cc:29:
:info:build In file included from ./array/Array.h:29:
:info:build In file included from /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/../include/c++/v1/cassert:21:
:info:build In file included from /usr/include/assert.h:44:
:info:build ../libgnu/stdlib.h:668:19: error: no member named 'mkostemp' in the global namespace

It seems to be the same as ​this homebrew issue

[mf2k (Frank Schima)]

Please do not Cc openmaintainer@… because it is not a valid email address.

[roberthuston@…]

Cc Me!

[skymoo (Adam Mercer)]

Cc Me!

[ATL-Flaneur (Andreas Yankopolus)]

I'm experiencing the same problem trying to install Octave on my Sierra system.

[MacPorts@…]

I did not get this far. For me it won't even try to install because it wants qt4 which does not support sierra:

>sudo port uninstall octave
>sudo port clean octave
--->  Cleaning octave
>
>sudo port install octave
--->  Computing dependencies for octave
--->  Dependencies to be installed: qscintilla qt4-mac
--->  Fetching distfiles for qt4-mac
Error: qt4-mac does not currently build on OSX later than 10.11 'El Capitan'.
Error: org.macports.fetch for port qt4-mac returned: unsupported platform
Error: Failed to install qt4-mac
Please see the log file for port qt4-mac for details:
    /opt/local/var/macports/logs/_opt_local_var_macports_sources_rsync.macports.org_release_tarballs_ports_aqua_qt4-mac/qt4-mac/main.log
Error: The following dependencies were not installed: qscintilla qt4-mac
To report a bug, follow the instructions in the guide:
    http://guide.macports.org/#project.tickets
Error: Processing of port octave failed
>

[ATL-Flaneur (Andreas Yankopolus)]

Replying to MacPorts@…:

I did not get this far. For me it won't even try to install because it wants qt4 which does not support sierra:

This just got fixed under #52208. Do a selfupdate, and qt4-mac will install just fine.

[MacPorts@…]

Cc Me!

[Schamschula (Marius Schamschula)]

Cc Me!

[captainproton1971 (Captain Proton)]

Cc Me!

[ryandesign (Ryan Carsten Schmidt)]

Has duplicate #52325.

[rz10@…]

This appears to have been addressed by the fix in the ​referenced homebrew issue. Should be a simple fix, right?

[rz10@…]

Cc Me!

[skymoo (Adam Mercer)]

Should be something like:

diff --git a/math/octave/Portfile b/math/octave/Portfile
index b0e43f3..379b0ae 100644
--- a/math/octave/Portfile
+++ b/math/octave/Portfile
@@ -82,6 +82,9 @@ configure.env-append MKDIR_P="/bin/mkdir -p"
 # avoid depends_build-append port:cctools
 configure.env-append RANLIB=/usr/bin/ranlib

+# workaround for build failure with Xcode8 (#52301)
+configure.env-append "ac_cv_func_mkostemp=no"
+
 # main octave port lists as a depends_lib
 # configure.ac list it among the "[p]rograms used in Makefiles"
 depends_build-append port:gawk

Currently running a test build...

[Schamschula (Marius Schamschula)]

Replying to ram@…:

Should be something like:

diff --git a/math/octave/Portfile b/math/octave/Portfile
index b0e43f3..379b0ae 100644
--- a/math/octave/Portfile
+++ b/math/octave/Portfile
@@ -82,6 +82,9 @@ configure.env-append MKDIR_P="/bin/mkdir -p"
 # avoid depends_build-append port:cctools
 configure.env-append RANLIB=/usr/bin/ranlib

+# workaround for build failure with Xcode8 (#52301)
+configure.env-append "ac_cv_func_mkostemp=no"
+
 # main octave port lists as a depends_lib
 # configure.ac list it among the "[p]rograms used in Makefiles"
 depends_build-append port:gawk

Currently running a test build...

I just successfully built octave 4.0.3 with a similar patch file using Xcode 8.0 under macOS Sierra.

[skymoo (Adam Mercer)]

Replying to mps@…:

I just successfully built octave 4.0.3 with a similar patch file using Xcode 8.0 under macOS Sierra.

My build completed successfully as well. Now testing octave-devel.

[Schamschula (Marius Schamschula)]

Replying to ram@…:

Replying to mps@…:

I just successfully built octave 4.0.3 with a similar patch file using Xcode 8.0 under macOS Sierra.

My build completed successfully as well. Now testing octave-devel.

Be mindful that all versions of octave-devel are currently out of date (this should be a separate ticket). I have just built a local version of octave-devel-rc 4.2.0-rc2 with the same patch.

[skymoo (Adam Mercer)]

Replying to mps@…:

Be mindful that all versions of octave-devel are currently out of date (this should be a separate ticket). I have just built a local version of octave-devel-rc 4.2.0-rc2 with the same patch.

Same here, I'll get this change pushed and updating octave-devel to a more recent versions can be dealt with separately.

[skymoo (Adam Mercer)]

r153046