Opened 8 years ago

Closed 7 years ago

Last modified 7 years ago

#52318 closed defect (fixed)

libproxy KDE variant modifications

Reported by: RJVB (René Bertin) Owned by: dbevans (David B. Evans)
Priority: Normal Milestone:
Component: ports Version:
Keywords: haspatch Cc: mkae (Marko Käning)
Port: libproxy

Description

The current port:libproxy's +KDE variant doesn't actually have any effect. The KDE module is built even without it.

In itself that's fine because that module now has a pure runtime dependency on KDE, but that also means that the +KDE variant no longer needs to pull in hard KDE dependencies.

The attached patch is a proposition. Since it's entirely unclear what use the KDE module has I have decided not to make it depend on any KDE or Qt port because a priori it won't even be used if no KDE software asks for it. And I have yet to find evidence that this is the case. There are no repercussions on the reproducible build principle.

I did include one additional change: with KDE being based on Qt/Cocoa (= using native APIs) it seems reasonable to let libproxy use native APIs too.

Is there a reason why this isn't the default, BTW, why libproxy isn't always built against native APIs which allow it to actually detect the system proxy correctly?

Attachments (1)

libproxy.diff (1.6 KB) - added by RJVB (René Bertin) 8 years ago.

Download all attachments as: .zip

Change History (5)

Changed 8 years ago by RJVB (René Bertin)

Attachment: libproxy.diff added

comment:1 Changed 8 years ago by mf2k (Frank Schima)

Cc: devans@… removed
Owner: changed from macports-tickets@… to devans@…

comment:2 Changed 8 years ago by mkae (Marko Käning)

Cc: mk@… added

Cc Me!

comment:3 Changed 7 years ago by dbevans (David B. Evans)

Resolution: fixed
Status: newclosed

KDE variant/plugin configuration issues addressed in changeset ce7ea3c

comment:4 Changed 7 years ago by dbevans (David B. Evans)

In 9131d80d69df5e438c4e5379d8c2efc0f553dcfb/macports-ports:

libproxy: unconditionally enable KF5/KDE4 support

Remove unnecessary +kde variant.

See #52318

Note: See TracTickets for help on using tickets.