Opened 8 years ago

Closed 8 years ago

Last modified 8 years ago

#52328 closed defect (fixed)

opencv @3.1.0: fatal error: 'QTKit/QTKit.h' file not found

Reported by: jefrey_c@… Owned by: stromnov (Andrey Stromnov)
Priority: Normal Milestone:
Component: ports Version:
Keywords: sierra Cc: andre.david@…, vitalys@…, nortcele, cs0rfecs0rfe (Ian Ferguson), victor.borjas@…, milutz@…, mkae (Marko Käning), rjvb, BSeppke (Benjamin Seppke), themightyoarfish (Rasmus), vanhoavn, tmenguy, amphioxus, FredMaris (Frédéric Maris), mcruggs, lauracrews, karo11, anandman (anand m), tscholak (Torsten Scholak), xrobin (Xavier Robin)
Port: opencv

Description (last modified by ryandesign (Ryan Carsten Schmidt))

:info:build /opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_release_tarballs_ports_graphics_opencv/opencv/work/opencv-3.1.0/modules/videoio/src/cap_qtkit.mm:46:9: fatal error: 'QTKit/QTKit.h' file not found
:info:build #import <QTKit/QTKit.h>
:info:build         ^

Seems to be an an issue with removal of QTKit in XCode 8? https://github.com/opencv/opencv/pull/7159

Attachments (7)

main.log (123.0 KB) - added by jefrey_c@… 8 years ago.
log file for port opencv
opencv_Portfile.diff (3.8 KB) - added by mkae (Marko Käning) 8 years ago.
Portfile diff against current
patch-find-openexr.diff (821 bytes) - added by mkae (Marko Käning) 8 years ago.
patch-pchsupport.diff (1.0 KB) - added by mkae (Marko Käning) 8 years ago.
patch-use-avfound-no-qtkit.diff (1.9 KB) - added by mkae (Marko Käning) 8 years ago.
cmake-1.1.tcl (13.3 KB) - added by mkae (Marko Käning) 8 years ago.
The new cmake port group version 1.1 (which deserves a separate ticket for discussion, I suppose)
opencv_Portfile.2.diff (3.6 KB) - added by nortcele 8 years ago.
Portfile diff against current

Download all attachments as: .zip

Change History (49)

Changed 8 years ago by jefrey_c@…

Attachment: main.log added

log file for port opencv

comment:1 Changed 8 years ago by ryandesign (Ryan Carsten Schmidt)

Description: modified (diff)
Keywords: sierra added
Owner: changed from macports-tickets@… to stromnov@…

comment:2 Changed 8 years ago by andre.david@…

Cc: andre.david@… added

Cc Me!

comment:3 Changed 8 years ago by vitalys@…

The fix was merged to opencv trunk, but they aren't going to release v3.1.x. v3.2 planned for 2016 Q4. Is there any chance to update the port with trunk sources?

Last edited 8 years ago by vitalys@… (previous) (diff)

comment:4 Changed 8 years ago by vitalys@…

Cc: vitalys@… added

Cc Me!

comment:5 Changed 8 years ago by nortcele

Cc: Joel.Brogniart@… added

Cc Me!

comment:6 Changed 8 years ago by tmenguy

Cc: thomas.menguy@… added

Cc Me!

comment:7 Changed 8 years ago by cs0rfecs0rfe (Ian Ferguson)

Cc: ian.ferguson@… added

Cc Me!

comment:8 Changed 8 years ago by victor.borjas@…

Last edited 8 years ago by victor.borjas@… (previous) (diff)

comment:9 Changed 8 years ago by victor.borjas@…

Cc: victor.borjas@… added

Cc Me!

comment:10 Changed 8 years ago by milutz@…

Relevant links:

I don't know how to take advantage of the above because I don't know how to force the port to have build options outside of what is defined in the variants (which videoio isn't) and/or force it to build off of the repo HEAD (as the homebrew people can)

comment:11 Changed 8 years ago by milutz@…

Cc: milutz@… added

Cc Me!

comment:12 Changed 8 years ago by mkae (Marko Käning)

Cc: mkae added

comment:13 Changed 8 years ago by mkae (Marko Käning)

Cc: rjvb added
Version: 2.3.4

Duplicate in #52697

Changed 8 years ago by mkae (Marko Käning)

Attachment: opencv_Portfile.diff added

Portfile diff against current

comment:14 Changed 8 years ago by mkae (Marko Käning)

Please note, that above patch relies on cmake portgroup's version 1.1, which isn't yet released. (@RJVB, I've added ticket #52699 where you might want to add some comments as description.)

I'll append the missing patch files in a second step now...

Last edited 8 years ago by ryandesign (Ryan Carsten Schmidt) (previous) (diff)

Changed 8 years ago by mkae (Marko Käning)

Attachment: patch-find-openexr.diff added

Changed 8 years ago by mkae (Marko Käning)

Attachment: patch-pchsupport.diff added

Changed 8 years ago by mkae (Marko Käning)

Changed 8 years ago by mkae (Marko Käning)

Attachment: cmake-1.1.tcl added

The new cmake port group version 1.1 (which deserves a separate ticket for discussion, I suppose)

comment:15 Changed 8 years ago by mkae (Marko Käning)

For a final release within MacPorts it might be questionable to use the linux platform-specific bits in opencv_Portfile.diff...

comment:16 Changed 8 years ago by BSeppke (Benjamin Seppke)

Cc: BSeppke added

comment:17 Changed 8 years ago by themightyoarfish (Rasmus)

Cc: themightyoarfish added

comment:18 Changed 8 years ago by vanhoavn

Cc: vanhoavn added

comment:19 Changed 8 years ago by tmenguy

Thanks a lot @mkae ... but excuse my freshness ... but how do I apply your patches and this cmake group 1.1? Thanks for your work, and your help!

Last edited 8 years ago by tmenguy (previous) (diff)

comment:20 Changed 8 years ago by tmenguy

Cc: tmenguy removed

comment:21 Changed 8 years ago by tmenguy

Cc: tmenguy added

comment:22 Changed 8 years ago by amphioxus

Cc: amphioxus added

comment:23 Changed 8 years ago by ryandesign (Ryan Carsten Schmidt)

Cc: FredMaris mcruggs lauracrews added
Summary: opencv 3.1.0 fails build on macOS Sierraopencv @3.1.0: fatal error: 'QTKit/QTKit.h' file not found

Has duplicate #52747.

comment:24 in reply to:  19 Changed 8 years ago by mkae (Marko Käning)

Replying to tmenguy:

Thanks a lot @mkae ... but excuse my freshness ... but how do I apply your patches and this cmake group 1.1? Thanks for your work, and your help!

Sorry for my late response, but I was waiting for the owner to test the patches... You could apply them yourselves to a local ports tree until the ticket owner commits this.

On the other hand this ticket us beyond maintainer timeout, so I might make the changes myself or at least file a review request for this port... Need to see whether I find the time for this during the weekend. Stay tuned and patient, please.

Last edited 8 years ago by mkae (Marko Käning) (previous) (diff)

comment:25 Changed 8 years ago by tmenguy

No pb @mkae, that would be awesome if you could do something ... in all case enjoy your week end

comment:26 Changed 8 years ago by karo11

Is there any chance to get opencv with MacOS Sierra functional in near future ?

comment:27 Changed 8 years ago by karo11

Cc: karo11 added

comment:28 Changed 8 years ago by tmenguy

@karo11 the provided patches are working well for me ... (except the portfile one, you need to adapt i a bit, but very easy) ...

comment:29 Changed 8 years ago by karo11

Hmm, encouraging! Still macports has in meantime a version change. I don't know if I should try to mingle into?

comment:30 Changed 8 years ago by stromnov (Andrey Stromnov)

Hi! Feel free to provide pull request for OpenCV 3.1.0 which will not break compatibility with older macOS releases (at least 10.9, 10.10 and 10.11 with new XCode).

comment:31 Changed 8 years ago by anandman (anand m)

Cc: anandman added

comment:32 Changed 8 years ago by tmenguy

@karo11 : was like you, but needed to make it work ... for my work, very quick to do

comment:33 Changed 8 years ago by mkae (Marko Käning)

@tmenguy, what exactly did you do? Did you use the set of patches I've uploaded 3 weeks ago?

If this is it, I can, of course, create a PR, as @stromnov is not going to do so.

But before I do that I'd like to learn what you did, @tmenguy. :)

Which OSX/macOS versions did you test your modified opencv port on?

Last edited 8 years ago by mkae (Marko Käning) (previous) (diff)

comment:34 Changed 8 years ago by tscholak (Torsten Scholak)

Last edited 8 years ago by tscholak (Torsten Scholak) (previous) (diff)

comment:35 Changed 8 years ago by tscholak (Torsten Scholak)

Cc: tscholak added

comment:36 Changed 8 years ago by nortcele

I tested the proposed modifications on macOS 10.12.1, the build and installation worked for me. I have not tested all opencv functions but I installed a software that depends on opencv and the sofware worked as expected.

To build opencv, I first cleaned and uninstalled all installed ports.

Then I updated Macports.

Then I duplicated Macports opencv folder to my local repository with Macport set to use my local repository. Then I added the three proposed patches in the "files" subfolder. I modified the Portfile file with your proposed modifications (I'll add a new version of the patch as this file has changed since yours).

And then "sudo install opencv".

I am reproducing the same steps on another machine with 10.12.1 too but as it is a really slower machine and as I have a customised GCC5 dependance, it is still building.

In some days I'll try the same steps with macOS 10.10 and 10.9…

Last edited 8 years ago by nortcele (previous) (diff)

Changed 8 years ago by nortcele

Attachment: opencv_Portfile.2.diff added

Portfile diff against current

comment:37 Changed 8 years ago by xrobin (Xavier Robin)

Cc: xrobin added

comment:38 in reply to:  36 Changed 8 years ago by nortcele

Replying to nortcele:

In some days I'll try the same steps with macOS 10.10 and 10.9…

I tested the same operations on 10.9.5 and 10.10.5 and it worked too.

comment:39 Changed 8 years ago by mkae (Marko Käning)

@rjvb, should this

-DENABLE_SSSE3=ON

perhaps rather be

-DENABLE_SSE3=ON

???

comment:40 Changed 8 years ago by RJVB (René Bertin)

Resolution: fixed
Status: newclosed

In 76d988f/macports-ports:

opencv: fix opencv for Sierra

Closes: #52328

comment:41 Changed 8 years ago by RJVB (René Bertin)

In 76d988f/macports-ports:

opencv: fix opencv for Sierra

Closes: #52328

comment:42 Changed 8 years ago by RJVB (René Bertin)

In 76d988f/macports-ports:

opencv: fix opencv for Sierra

Closes: #52328

Note: See TracTickets for help on using tickets.