phantomjs @2.0.0: failing to build in macOS Sierra

[andre.david@…]

phantomjs @2.0.0_1 is failing to build with Mac OSX Sierra (10.12):

:info:build System architecture... (Darwin 16.0.0 x86_64)
:info:build    Xcode not set up properly. You may need to confirm the license
:info:build    agreement by running /usr/bin/xcodebuild without arguments.

Of course this is not the source of the problem, since the build system is working for all other ports.

[andre.david@…]

Sorry for the bad formatting in the description as well as the missing port information.

[ioquatix (Samuel Williams)]

I'm also having this problem.

[ioquatix (Samuel Williams)]

It looks like because of this

    if ! /usr/bin/xcrun -find xcrun >/dev/null 2>&1; then
        echo >&2
        echo "   Xcode not set up properly. You may need to confirm the license" >&2
        echo "   agreement by running /usr/bin/xcodebuild without arguments." >&2
        echo >&2
        exit 2
    fi

in src/qt/qtbase/configure

I could fix it by changing to

    if ! /usr/bin/xcrun -find xcodebuild >/dev/null 2>&1; then
        echo >&2
        echo "   Xcode not set up properly. You may need to confirm the license" >&2
        echo "   agreement by running /usr/bin/xcodebuild without arguments." >&2
        echo >&2
        exit 2
    fi

and in src/qt/qtbase/mkspecs/features/mac/default_pre.prf

    # Make sure Xcode is set up properly
    isEmpty($$list($$system("/usr/bin/xcrun -find xcodebuild 2>/dev/null"))): \
        error("Xcode not set up properly. You may need to confirm the license agreement by running /usr/bin/xcodebuild.")

[ioquatix (Samuel Williams)]

I think the solution here is to simply update the Portfile to version 2.1 which doesn't appear to have this problem.

[ioquatix (Samuel Williams)]

Actually, apparently 2.1.1 is the latest stable release, so that would be great!

[ioquatix (Samuel Williams)]

Here is the correct release to use:

​https://github.com/ariya/phantomjs/releases/tag/2.1.1

[ioquatix (Samuel Williams)]

I tried my best to make an updated Portfile but ultimately couldn't get it to work

​https://github.com/ariya/phantomjs/issues/14843

It would require a significant amount of fixing on our end which I don't think is the right approach.

[ryandesign (Ryan Carsten Schmidt)]

Has duplicate #53919.

Replying to ioquatix:

I think the solution here is to simply update the Portfile to version 2.1 which doesn't appear to have this problem.

This ticket is about the build failure on Sierra. Updating to 2.1.1 is tracked separately, in #51965.

Replying to ioquatix:

It looks like because of this

    if ! /usr/bin/xcrun -find xcrun >/dev/null 2>&1; then
        echo >&2
        echo "   Xcode not set up properly. You may need to confirm the license" >&2
        echo "   agreement by running /usr/bin/xcodebuild without arguments." >&2
        echo >&2
        exit 2
    fi

in src/qt/qtbase/configure

I could fix it by changing to

    if ! /usr/bin/xcrun -find xcodebuild >/dev/null 2>&1; then
        echo >&2
        echo "   Xcode not set up properly. You may need to confirm the license" >&2
        echo "   agreement by running /usr/bin/xcodebuild without arguments." >&2
        echo >&2
        exit 2
    fi

and in src/qt/qtbase/mkspecs/features/mac/default_pre.prf

    # Make sure Xcode is set up properly
    isEmpty($$list($$system("/usr/bin/xcrun -find xcodebuild 2>/dev/null"))): \
        error("Xcode not set up properly. You may need to confirm the license agreement by running /usr/bin/xcodebuild.")

This is what the developers of Qt appear to have done in the current version of Qt, so I feel fine with making that change in phantomjs, to hold us over until we can figure out how to update to a newer version.

[ryandesign (Ryan Carsten Schmidt)]

In e7365db3a7b3164c64fa1e931a4d2945a1ed8693/macports-ports:

phantomjs: Fix build on Sierra

Closes: #52365