Opened 8 years ago

Closed 8 years ago

#52395 closed defect (fixed)

webkit-gtk fails to build: no member named RedirectedXCompositeWindow - reprise

Reported by: ken-cunningham-webuse Owned by: jeremyhu (Jeremy Huddleston Sequoia)
Priority: Normal Milestone:
Component: ports Version: 2.3.4
Keywords: Cc: dbevans (David B. Evans)
Port: webkit-gtk

Description

This ticket is identical to 41663, but the same fix needs to be applied back to at least 10.6 as well.

In this block, I just set the OS major test back from 13 to 8, and now it builds fine on Snow Leopard with LibcxxOnOlderSystems. I'm trying to get it to build back to Tiger, so perhaps we might just set it to apply to all Darwin systems? 

    platform darwin {
        if {${os.major} >= 8} {
            # TODO: File upstream
            #       http://trac.macports.org/ticket/41663
            configure.args-append --disable-accelerated-compositing
        }
    }

The attached patch applies in the quartz block without system test, as this appears to be needed on all systems (and only Darwin can run the quartz block, AFAIK).

Attachments (2)

webkit-gtk-fail.main.log.gz​ (1.5 MB) - added by ken-cunningham-webuse 8 years ago.
build fail log
webkit-gtk-RedirectedXCompositeWindow-fix.diff​ (820 bytes) - added by ken-cunningham-webuse 8 years ago.
suggested patch

Download all attachments as: .zip

Change History (6)

Changed 8 years ago by ken-cunningham-webuse

Attachment: webkit-gtk-fail.main.log.gz​ added

build fail log

Changed 8 years ago by ken-cunningham-webuse

Attachment: webkit-gtk-RedirectedXCompositeWindow-fix.diff​ added

suggested patch

comment:1 Changed 8 years ago by mf2k (Frank Schima)

Cc: devans@… added; jeremyhu@… removed
Owner: changed from macports-tickets@… to jeremyhu@…

comment:2 Changed 8 years ago by jeremyhu (Jeremy Huddleston Sequoia)

The change should be based on what the C++ standard library is.

If you're using libc++, you should be using webkit2-gtk or webkit2-gtk-devel instead of webkit-gtk.

comment:3 Changed 8 years ago by jeremyhu (Jeremy Huddleston Sequoia)

Applied in r153186.

Filed #52398 to track ports moving over to webkit2, so we can remove this port completely.

comment:4 Changed 8 years ago by jeremyhu (Jeremy Huddleston Sequoia)

Resolution: → fixed
Status: new → closed
Note: See TracTickets for help on using tickets.