Opened 8 years ago
Closed 8 years ago
#52441 closed submission (fixed)
Add dnsviz port
Reported by: | cdeccio (Casey Deccio) | Owned by: | macports-tickets@… |
---|---|---|---|
Priority: | Normal | Milestone: | |
Component: | ports | Version: | |
Keywords: | Cc: | cdeccio (Casey Deccio) | |
Port: | dnsviz |
Description
Attachments (1)
Change History (8)
comment:1 follow-up: 2 Changed 8 years ago by ryandesign (Ryan Carsten Schmidt)
comment:2 Changed 8 years ago by cdeccio (Casey Deccio)
Thanks - all done. Please see new Portfile with applied changes.
The remainder is just a comment, with regard to the following:
- For ports that use the python portgroup but that provide apps, not python modules, specify only the single version of python that the port will use (or add variants to let the user choose which version of python they want, if that's important for this port).
This makes sense. For what it's worth the documentation is a bit misleading with the use of "default":
... and python.versions defaults to the value of python.default_version ...
(https://guide.macports.org/chunked/reference.portgroup.html)
It does later say "automatically set", but "default" can be confusing even so.
Thanks!
comment:5 follow-up: 6 Changed 8 years ago by cdeccio (Casey Deccio)
Just curious - is a pull request at the github site (https://github.com/macports/macports-ports) preferred to submitting tickets on the trac site for new ports?
comment:6 Changed 8 years ago by larryv (Lawrence Velázquez)
Neither is preferred. Use whichever method you are most comfortable with.
comment:7 Changed 8 years ago by mojca (Mojca Miklavec)
Resolution: | → fixed |
---|---|
Status: | new → closed |
Version: | 2.3.4 |
Note: See
TracTickets for help on using
tickets.
Thanks. Some comments:
${python.version}
variable, as inport:py${python.version}-dnspython