#52445 closed enhancement (fixed)
portpatch.tcl: support xz-compressed patchfiles
Reported by: | ryandesign (Ryan Carsten Schmidt) | Owned by: | macports-tickets@… |
---|---|---|---|
Priority: | Normal | Milestone: | MacPorts 2.5.0 |
Component: | base | Version: | |
Keywords: | Cc: | larryv (Lawrence Velázquez), mojca (Mojca Miklavec), kurthindenburg (Kurt Hindenburg) | |
Port: |
Description
portpatch.tcl already automatically handles patchfiles whose names end with .Z, .gz and .bz2, passing them through the appropriate decompressor first. Add support for xz-compressed files.
The complication is that a dependency on port:xz would have to be added since macOS doesn't include it.
Change History (9)
comment:1 Changed 8 years ago by larryv (Lawrence Velázquez)
Cc: | larryv@… added |
---|
comment:2 Changed 7 years ago by mojca (Mojca Miklavec)
Cc: | mojca added |
---|
comment:3 Changed 7 years ago by mojca (Mojca Miklavec)
Milestone: | → MacPorts 2.6.0 |
---|
comment:4 Changed 7 years ago by kurthindenburg (Kurt Hindenburg)
Cc: | kurthindenburg added |
---|
My attempt at adding depends_patch https://github.com/macports/macports-base/pull/66
If committed, I'll make another pull to use it for patches.
comment:5 Changed 7 years ago by Kurt Hindenburg <kurt.hindenburg@…>
comment:6 follow-up: 7 Changed 7 years ago by kurthindenburg (Kurt Hindenburg)
https://github.com/macports/macports-base/pull/67
Note that this doesn't allow use of tar.xz patch files such as w3m_0.5.3-36.debian.tar.xz - that would need another patch
comment:7 Changed 7 years ago by ryandesign (Ryan Carsten Schmidt)
Replying to kurthindenburg:
Note that this doesn't allow use of tar.xz patch files such as w3m_0.5.3-36.debian.tar.xz - that would need another patch
I would consider that a completely separate feature, to be dealt with in another ticket, following perhaps first a mailing list discussion in which the feature is proposed and specified. MacPorts doesn't support .tar.gz or .tar.bz2 "patch files" either. A tar file could (and the example w3m_0.5.3-36.debian.tar.xz file does) contain multiple files, not all of which are patches; it's not immediately clear how or if MacPorts should handle that.
comment:8 Changed 7 years ago by Kurt Hindenburg <kurt.hindenburg@…>
Resolution: | → fixed |
---|---|
Status: | new → closed |
comment:9 Changed 7 years ago by jmroot (Joshua Root)
Milestone: | MacPorts 2.6.0 → MacPorts 2.5.0 |
---|
Cc Me!