webkit2-gtk +quartz: undefined symbols error

[aque (Allan Que)]

I get an error building webkit2-gtk with +quartz under 10.12.

:info:build Undefined symbols for architecture x86_64:
:info:build   "WebCore::GLContext::createSharingContext(WebCore::PlatformDisplay&)", referenced from:
:info:build       WebCore::PlatformDisplay::sharingGLContext() in libWebCorePlatformGTK.a(PlatformDisplay.cpp.o)
:info:build ld: symbol(s) not found for architecture x86_64
:info:build clang: error: linker command failed with exit code 1 (use -v to see invocation)
:info:build make[2]: *** [lib/libwebkit2gtk-4.0.37.14.7.dylib] Error 1

Running Xcode 8.0 (8A218a). I tried rm -rf /opt/local and got the same results.

[jeremyhu (Jeremy Huddleston Sequoia)]

Does webkit2-gtk-devel build for you? I'll probably be updating webkit2-gtk to that version soon.

[aque (Allan Que)]

webkit2-gtk-devel also fails with the same error.

[aque (Allan Que)]

webkit2-gtk-devel main.log

[e-t-h-a-n]

Cc Me!

[dbevans (David B. Evans)]

Has duplicate #52501.

[p-bro]

I have the same error on El Capitan (10.11.6).

[p-bro]

Cc Me!

[EdHarry]

Cc Me!

[jeremyhu (Jeremy Huddleston Sequoia)]

The call site in WebCore/platform/graphics/PlatformDisplay.cpp is:

#if !PLATFORM(EFL)
GLContext* PlatformDisplay::sharingGLContext()
{
    if (!m_sharingGLContext)
        m_sharingGLContext = GLContext::createSharingContext(*this);
    return m_sharingGLContext.get();
}
#endif

The declaration in WebCore/platform/graphics/GLContext.h is:

namespace WebCore {

class GLContext {
...
public:
...
    static std::unique_ptr<GLContext> createSharingContext(PlatformDisplay&);

Looking in WebCore/platform/graphics/GLContext.cpp, it looks like it's only relevant for either GLX, EGL, or Wayland, so this should just not be used.

r154013 should fix the build by disabling this codepath.

[jeremyhu (Jeremy Huddleston Sequoia)]

devans reproduced in #52688, so he can probably figure out the fix. I'm not sure why the change I made didn't address the problem, but we should just be disabling WebGL support on +quartz. Can you investigate how to do that and why the r154013 change didn't have that effect?

[dbevans (David B. Evans)]

Will take a look. CCing email reporter of #52688.

[dbevans (David B. Evans)]

Just to be clear, this is not a Sierra specific issue. Has been reproduced on El Capitan and I suspect others as well.

[p-bro]

The error persists with @2.14.1_0+quartz. You may want to consider updating the bug summary.

[dbevans (David B. Evans)]

webkit2-gtk updated to version 2.14.2 in ​commit 134b99f. webkit2-gtk +quartz now builds successfully for me using Xcode 8.1 on both 10.12.2 public beta and 10.11.5. Should build on 10.10 and 10.9 as well. Not supported on earlier versions.

Please update your ports tree and rebuild.

[g5pw (Aljaž Srebrnič)]

Indeed it now builds fine for me. Thanks!