Opened 8 years ago

Closed 8 years ago

Last modified 8 years ago

#52498 closed update (fixed)

Qalculate update

Reported by: jjstickel (Jonathan Stickel) Owned by: macports-tickets@…
Priority: Normal Milestone:
Component: ports Version:
Keywords: haspatch maintainer Cc:
Port: libqalculate qalculate-gtk

Description

Qalculate has been updated upstream. Patches attached.

Attachments (2)

qalculate-gtk_Portfile.diff (1.1 KB) - added by jjstickel (Jonathan Stickel) 8 years ago.
libqalculate_Portfile.diff (1.3 KB) - added by jjstickel (Jonathan Stickel) 8 years ago.

Download all attachments as: .zip

Change History (7)

Changed 8 years ago by jjstickel (Jonathan Stickel)

Attachment: qalculate-gtk_Portfile.diff added

comment:1 Changed 8 years ago by jjstickel (Jonathan Stickel)

During the build of libqalculate, configure did not find the correct perl:

checking for perl >= 5.8.1... 5.22.2
checking for XML::Parser... configure: error: XML::Parser perl module is required for intltool

So it detected perl-5.22 rather than perl-5.24, which is needed because I have p5.24-xml-parser installed as the dependency for intltool. I am sure this was caused by the ongoing transition from perl-5.22 to perl-5.24. After reinstalling perl5 with +5_24 variant, libqalculate built fine. I don't think this should prevent committing this update, but perhaps we should add a configure option to point to the perl used for intltool dependencies? I am not sure how best to do that, though.

comment:2 Changed 8 years ago by ryandesign (Ryan Carsten Schmidt)

Any MacPorts port of a project that use intltool needs to regenerate its intltool files so that this XML::Parser location problem does not occur. See other ports that use intltool for examples.

Last edited 8 years ago by ryandesign (Ryan Carsten Schmidt) (previous) (diff)

Changed 8 years ago by jjstickel (Jonathan Stickel)

Attachment: libqalculate_Portfile.diff added

comment:3 in reply to:  2 Changed 8 years ago by jjstickel (Jonathan Stickel)

Replying to ryandesign@…:

Any MacPorts port of a project that use intltool needs to regenerate its intltool files so that this XML::Parser location problem does not occur. See other ports that use intltool for examples.

OK, got it. Not understanding the need, I deleted lines for this in a recent version. I have added them back in the attached patch. Please commit.

comment:4 Changed 8 years ago by mf2k (Frank Schima)

Resolution: fixed
Status: newclosed
Version: 2.3.4

r153843.

I took the liberty of adding the autoreconf code block to the qalculate-gtk Portfile too because it failed with the same error.

Last edited 8 years ago by mf2k (Frank Schima) (previous) (diff)

comment:5 in reply to:  4 Changed 8 years ago by jjstickel (Jonathan Stickel)

Replying to mf2k@…:

r153843.

I took the liberty of adding the autoreconf code block to the qalculate-gtk Portfile too because it failed with the same error.

Great! I didn't notice qalculate-gtk needed that too, so thanks for catching it.

Note: See TracTickets for help on using tickets.