ctorrent does not build on macOS Sierra

[vb@…]

:info:build In file included from compat.c:11:
:info:build ./compat.h:23:13: error: typedef redefinition with different types ('int' vs 'enum clockid_t')
:info:build typedef int clockid_t;
:info:build             ^
:info:build /usr/include/time.h:171:3: note: previous definition is here
:info:build } clockid_t;
:info:build   ^
:info:build 1 error generated.

[larryv (Lawrence Velázquez)]

Please run sudo port clean ctorrent, try building again, and attach the full main.log to this ticket.

[ken-cunningham-webuse]

something not working right in the configuration on Sierra. The uploaded patch fixes the symptom and allows the build, but does not debug why it's occurring.

The following ports are currently installed:
  ctorrent @3.3.2_2 (active) platform='darwin 16' archs='x86_64'
$ ctorrent
Enhanced CTorrent dnh3.3.2   Original code Copyright: YuHong(992126018601033)
WARNING: THERE IS NO WARRANTY FOR CTorrent. USE AT YOUR OWN RISK!!!

General Options:
-h/-H           Show this message
-x              Decode metainfo (torrent) file only, don't download
-c              Check pieces only, don't download
-v              Verbose output (for debugging)

[larryv (Lawrence Velázquez)]

This should be fixed with a patch, not a reinplace.

[ken-cunningham-webuse]

Replying to larryv@…:

This should be fixed with a patch, not a reinplace.

I like reinplaces for these two-character changes -- way faster to do and test. Why would you like this to be a patch?

[larryv (Lawrence Velázquez)]

Patches are more explicit, provide context, are less likely to break in the future, and allow adding explanatory metadata.

The fix is subpar, in any case. The correct fix is to improve the preprocessor condition so that building on Sierra does not trigger the typedef.

[ken-cunningham-webuse]

I'll learn from what you come up with.

[larryv (Lawrence Velázquez)]

I can’t promise anything, but I’ll try to take a look within the next couple of days.

[ken-cunningham-webuse]

I suppose it comes down to a question of how much effort it is worth.

This is a small port. It's broken for anyone who uses this app and has upgraded to sierra. They are frustrated.

The two character fix I made works perfectly. Anything fancier for a fix will not make it work any better. Done. If you want to comment it further, it's easy enough to do. The fix references this ticket, which is all the commenting I would ever need.

The clean and proper fix upstream may come someday -- or it may never come -- but in the meantime, why spend another second on this fixed port? There is _way_ too much other stuff to be done to fuss another moment on this. For me anyway.

But that's my way -- I'm extremely practical. I don't have any interest (really) in fixing the configure logic for the ctorrent application -- upstream can do that.

[larryv (Lawrence Velázquez)]

Please look at this from a broader perspective. We wish to encourage habits that improve maintainability across the project. One of those habits is to prefer patches over install-time substitutions, except where absolutely necessary.

I just fixed this in a robust way in r154030; one would be hard-pressed to call it “fancy”. It did not take very much time and is easy to translate into a concrete fix for upstream to consider. You might argue that it was only simple because I have been doing this for a while, but it would not have been simple had I decided that I wasn’t ever going to bother digging into configure scripts and wading through autoconf to understand how it works. Taking time up front to learn the build systems pays dividends down the road.

[ken-cunningham-webuse]

accepted. please accept my apologies. only human. --K