atom 1.20.0: submission

[someuser12]

Submitting a Portfile for the Atom text editor.

[kurthindenburg (Kurt Hindenburg)]

Did this port actually work for you? I couldn't get it to work and it didn't appear an easy fix.

[someuser12]

1. There is a missing dependency to npm (can be npm2, npm3 or npm4, so I suggest adding path:bin/npm:npm4).

2. It works for me under Mac OS 10.8.5 which has python2 as default Python, but not in the present state under Mac OS 10.11 which has python3 as default Python. A solution to that issue needs to be found.

[kurthindenburg (Kurt Hindenburg)]

Working portfile for 1.20.0

[kurthindenburg (Kurt Hindenburg)]

Here's a working version for 1.20.0 - it does a lot of extra downloading and seems to work OK

[mf2k (Frank Schima)]

Given this line:

supported_archs     noarch

I don't see the need for the following lines:

build.env-append    CC="${configure.cc} [get_canonical_archflags cc]" \
                    CXX="${configure.cxx} [get_canonical_archflags cxx]"

and

universal_variant   no

[raimue (Rainer Müller)]

While you declared a dependency on python27, you also need to ensure the build is actually using python2.7 and not the plain python which could be another selected version. That seems to be very deeply buried in the build system, but according to the build instructions for Linux, it respects PYTHON in the environment.

Portfile

@@ -25 +25 @@
 use_configure       no
 build.cmd           script/build
 build.env-append    CC="${configure.cc} [get_canonical_archflags cc]" \
-                    CXX="${configure.cxx} [get_canonical_archflags cxx]"
+                    CXX="${configure.cxx} [get_canonical_archflags cxx]" \
+                    PYTHON="${prefix}/bin/python2.7"
 build.args-append   --install-dir ${destroot}${applications_dir}/Atom.app
 build.target-delete all
 

[kurthindenburg (Kurt Hindenburg)]

Thanks, I added the python line and I've removed this line "supported_archs noarch" as there are binaries which I assume would mean they are arch related.

[kurthindenburg (Kurt Hindenburg)]

In 1cf71473e243b67610ed7a32001592f3fa2e330b/macports-ports:

atom: new port

closes #52589