Opened 8 years ago

Closed 7 years ago

#52589 closed submission (fixed)

atom 1.20.0: submission

Reported by: someuser12 Owned by: macports-tickets@…
Priority: Normal Milestone:
Component: ports Version:
Keywords: Cc: kurthindenburg (Kurt Hindenburg)
Port: atom

Description

Submitting a Portfile for the Atom text editor.

Attachments (2)

Portfile (782 bytes) - added by someuser12 8 years ago.
Portfile.2 (1.2 KB) - added by kurthindenburg (Kurt Hindenburg) 7 years ago.
Working portfile for 1.20.0

Download all attachments as: .zip

Change History (9)

Changed 8 years ago by someuser12

Attachment: Portfile added

comment:1 Changed 8 years ago by kurthindenburg (Kurt Hindenburg)

Cc: kurthindenburg added
Version: 2.3.4

Did this port actually work for you? I couldn't get it to work and it didn't appear an easy fix.

comment:2 in reply to:  1 Changed 8 years ago by someuser12

  1. There is a missing dependency to npm (can be npm2, npm3 or npm4, so I suggest adding path:bin/npm:npm4).
  1. It works for me under Mac OS 10.8.5 which has python2 as default Python, but not in the present state under Mac OS 10.11 which has python3 as default Python. A solution to that issue needs to be found.

Changed 7 years ago by kurthindenburg (Kurt Hindenburg)

Attachment: Portfile.2 added

Working portfile for 1.20.0

comment:3 Changed 7 years ago by kurthindenburg (Kurt Hindenburg)

Summary: atom 1.10.2: submissionatom 1.20.0: submission

Here's a working version for 1.20.0 - it does a lot of extra downloading and seems to work OK

comment:4 Changed 7 years ago by mf2k (Frank Schima)

Given this line:

supported_archs     noarch

I don't see the need for the following lines:

build.env-append    CC="${configure.cc} [get_canonical_archflags cc]" \
                    CXX="${configure.cxx} [get_canonical_archflags cxx]"

and

universal_variant   no

comment:5 Changed 7 years ago by raimue (Rainer Müller)

While you declared a dependency on python27, you also need to ensure the build is actually using python2.7 and not the plain python which could be another selected version. That seems to be very deeply buried in the build system, but according to the build instructions for Linux, it respects PYTHON in the environment.

  • Portfile

     
    2525use_configure       no
    2626build.cmd           script/build
    2727build.env-append    CC="${configure.cc} [get_canonical_archflags cc]" \
    28                     CXX="${configure.cxx} [get_canonical_archflags cxx]"
     28                    CXX="${configure.cxx} [get_canonical_archflags cxx]" \
     29                    PYTHON="${prefix}/bin/python2.7"
    2930build.args-append   --install-dir ${destroot}${applications_dir}/Atom.app
    3031build.target-delete all
    3132

comment:6 Changed 7 years ago by kurthindenburg (Kurt Hindenburg)

Thanks, I added the python line and I've removed this line "supported_archs noarch" as there are binaries which I assume would mean they are arch related.

comment:7 Changed 7 years ago by kurthindenburg (Kurt Hindenburg)

Resolution: fixed
Status: newclosed
Note: See TracTickets for help on using tickets.