Opened 8 years ago
Closed 8 years ago
#52626 closed enhancement (fixed)
Remove svn.macports.org distfiles fallback
Reported by: | ryandesign (Ryan Carsten Schmidt) | Owned by: | macports-tickets@… |
---|---|---|---|
Priority: | Normal | Milestone: | MacPorts 2.3.5 |
Component: | base | Version: | 2.3.4 |
Keywords: | Cc: | raimue (Rainer Müller), mkae (Marko Käning) | |
Port: |
Description
We should remove the svn.macports.org fallback for downloading distfiles. It has been many years since we told people not to put new distfiles there anymore.
Any ancient port that actually has its files stored there can specify master_sites macports
, as these ports do:
$ find . -name Portfile | xargs grep -E 'master_sites[[:space:]]+macports[[:space:]]*$' ./aqua/Freecell/Portfile:master_sites macports ./aqua/macsword/Portfile:master_sites macports ./devel/libcipher/Portfile:master_sites macports ./devel/libgnugetopt/Portfile:master_sites macports ./fuse/sshfs-gui/Portfile:master_sites macports ./games/fortune/Portfile:master_sites macports ./games/wump/Portfile:master_sites macports ./graphics/libxdkwrl/Portfile:master_sites macports ./math/bcv/Portfile:master_sites macports ./math/ocaml-buddy/Portfile:master_sites macports ./net/fetch/Portfile:master_sites macports ./net/libfetch/Portfile:master_sites macports ./net/scotty/Portfile:master_sites macports ./python/py-pipedream/Portfile:master_sites macports ./sysutils/bdes/Portfile:master_sites macports ./sysutils/port_cutleaves/Portfile:master_sites macports ./textproc/flip/Portfile:master_sites macports
Attachments (1)
Change History (7)
comment:1 Changed 8 years ago by raimue (Rainer Müller)
Cc: | raimue@… added |
---|
comment:2 Changed 8 years ago by ryandesign (Ryan Carsten Schmidt)
It's a base issue; see browser:trunk/base/src/port1.0/portfetch.tcl?rev=146644#L119
I don't know if we can just set fallback_mirror_site
to empty or if we have to remove all references to fallback_mirror_site
from the code.
Changed 8 years ago by raimue (Rainer Müller)
Attachment: | remove-fallback_mirror_site.diff added |
---|
comment:3 Changed 8 years ago by raimue (Rainer Müller)
If we agree there is no need for a fallback anymore, here is a patch that removes it from base.
comment:4 Changed 8 years ago by mkae (Marko Käning)
Cc: | mkae added |
---|
comment:5 Changed 8 years ago by raimue (Rainer Müller)
Pull request: https://github.com/macports/macports-base/pull/5
comment:6 Changed 8 years ago by raimue (Rainer Müller)
Resolution: | → fixed |
---|---|
Status: | new → closed |
Note: See
TracTickets for help on using
tickets.
The fallback is defined in _resources/port1.0/fetch/mirror_sites.tcl, so it is not actually a issue with base.