Opened 8 years ago

Closed 8 years ago

#52758 closed defect (fixed)

asciidoc should depend on libxslt, dblatex, w3m, epubcheck

Reported by: ryandesign (Ryan Carsten Schmidt) Owned by: neverpanic (Clemens Lang)
Priority: Normal Milestone:
Component: ports Version: 2.3.4
Keywords: Cc: raimue (Rainer Müller)
Port: asciidoc

Description

The a2x program installed by the asciidoc port has these lines:

# External executables.
ASCIIDOC = 'asciidoc'
XSLTPROC = 'xsltproc'
DBLATEX = 'dblatex'         # pdf generation.
FOP = 'fop'                 # pdf generation (--fop option).
W3M = 'w3m'                 # text generation.
LYNX = 'lynx'               # text generation (if no w3m).
XMLLINT = 'xmllint'         # Set to '' to disable.
EPUBCHECK = 'epubcheck'     # Set to '' to disable.

So, should asciidoc have runtime dependencies on the ports that provide xsltproc (libxslt), dblatex (dblatex), w3m (w3m), epubcheck (epubcheck)?

See #42517 where the libxml2 dependency was already added because a2x uses xmllint.

The fop dependency has been there since changeset:2f224e8c/macports-ports

This might fix the build failure of tinyproxy.

Change History (5)

comment:1 Changed 8 years ago by raimue (Rainer Müller)

No objections to adding libxslt, since it is a common use case and we also already have libxml2.

However, dblatex adds a huge set of ports that most users might not need. Similarly, when asciidoc is installed as a dependency for building man pages, there is no need for w3m or epubcheck. If a port requires these tools, they should be added to that port.

comment:2 Changed 8 years ago by raimue (Rainer Müller)

Cc: raimue added

comment:3 Changed 8 years ago by neverpanic (Clemens Lang)

I agree. Will prepare a change.

comment:4 Changed 8 years ago by neverpanic (Clemens Lang)

Status: newaccepted

comment:5 Changed 8 years ago by neverpanic (Clemens Lang)

Resolution: fixed
Status: acceptedclosed

In 8709f8f8/macports-ports:

asciidoc: Depend on libxslt for xsltproc

Closes #52758

Note: See TracTickets for help on using tickets.