Opened 8 years ago
Closed 8 years ago
#52799 closed update (fixed)
ldas-tools-al 2.5.1 Added build tool dependencies
| Reported by: | emaros | Owned by: | macports-tickets@… |
|---|---|---|---|
| Priority: | Normal | Milestone: | |
| Component: | ports | Version: | |
| Keywords: | haspatch maintainer | Cc: | skymoo (Adam Mercer) |
| Port: | ldas-tools-al |
Description
Attachments (1)
Change History (7)
Changed 8 years ago by emaros
| Attachment: | Portfile-ldas-tools-al.diff added |
|---|
comment:1 Changed 8 years ago by ryandesign (Ryan Carsten Schmidt)
This patch increases the port's revision and adds the autoconf, automake and libtool build dependencies. In the absence of those dependencies, does the port build incorrectly, or not at all? I ask because I expect the answer is the latter, in which case there is no reason to increase the revision.
The same question applies to #52800, #52801, #52802, #52803, #52804, #52805. In the future it would be easier if you would use a single ticket for related changes, or a single GitHub pull request.
comment:2 follow-up: 3 Changed 8 years ago by emaros
So noted on the revision number.
As for the single GitHub pull request, which package should I use for port when submitting the patch?
If you wish, the tickets can be closed and I can produce a proper GitHub Pull request.
comment:3 Changed 8 years ago by skymoo (Adam Mercer)
Replying to emaros:
As for the single GitHub pull request, which package should I use for port when submitting the patch?
Which package to use for the ticket doesn't make sense for a pull request as there is no ticket.
comment:4 Changed 8 years ago by skymoo (Adam Mercer)
| Cc: | skymoo added |
|---|
comment:5 Changed 8 years ago by emaros
This ticket should now be satisfied by pull request:
https://github.com/macports/macports-ports/pull/20
comment:6 Changed 8 years ago by Ed Maros <ed.maros@…>
| Resolution: | → fixed |
|---|---|
| Status: | new → closed |
git format-patch style patch