Opened 8 years ago

Closed 8 years ago

#52799 closed update (fixed)

ldas-tools-al 2.5.1 Added build tool dependencies

Reported by: emaros Owned by: macports-tickets@…
Priority: Normal Milestone:
Component: ports Version:
Keywords: haspatch maintainer Cc: skymoo (Adam Mercer)
Port: ldas-tools-al

Description


Attachments (1)

Portfile-ldas-tools-al.diff (1.0 KB) - added by emaros 8 years ago.
git format-patch style patch

Download all attachments as: .zip

Change History (7)

Changed 8 years ago by emaros

Attachment: Portfile-ldas-tools-al.diff added

git format-patch style patch

comment:1 Changed 8 years ago by ryandesign (Ryan Carsten Schmidt)

This patch increases the port's revision and adds the autoconf, automake and libtool build dependencies. In the absence of those dependencies, does the port build incorrectly, or not at all? I ask because I expect the answer is the latter, in which case there is no reason to increase the revision.

The same question applies to #52800, #52801, #52802, #52803, #52804, #52805. In the future it would be easier if you would use a single ticket for related changes, or a single GitHub pull request.

Last edited 8 years ago by ryandesign (Ryan Carsten Schmidt) (previous) (diff)

comment:2 Changed 8 years ago by emaros

So noted on the revision number.

As for the single GitHub pull request, which package should I use for port when submitting the patch?

If you wish, the tickets can be closed and I can produce a proper GitHub Pull request.

comment:3 in reply to:  2 Changed 8 years ago by skymoo (Adam Mercer)

Replying to emaros:

As for the single GitHub pull request, which package should I use for port when submitting the patch?

Which package to use for the ticket doesn't make sense for a pull request as there is no ticket.

comment:4 Changed 8 years ago by skymoo (Adam Mercer)

Cc: skymoo added

comment:5 Changed 8 years ago by emaros

This ticket should now be satisfied by pull request:

https://github.com/macports/macports-ports/pull/20

comment:6 Changed 8 years ago by Ed Maros <ed.maros@…>

Resolution: fixed
Status: newclosed

In 375f4937/macports-ports:

ldas-tools-*: Add build dependency on pkgconfig

This addresses all 7 ldas-tools packages, which need pkgconfig as
a build dependency.

Closes: #52799
Closes: #52800
Closes: #52801
Closes: #52802
Closes: #52803
Closes: #52804
Closes: #52805
Closes: https://github.com/macports/macports-ports/pull/20

Note: See TracTickets for help on using tickets.