shairport-sync @2.8.6_0: submission

[ale275 (Alessandro Gritti)]

Submission of shairport-sync Portfile

[neverpanic (Clemens Lang)]

A couple of comments:

• For ports from GitHub, use PortGroup github 1.0 and call github.setup. In your case, the correct line would be github.setup mikebrady shairport-sync 2.8.6. That automatically sets version, homepage, fetch.type, git.url and git.branch properly, so you should remove those. It also automatically uses a tarball download, which allows better caching on our mirror infrastructure.
• The maintainer field does not (yet) accept GitHub usernames, so make this an email address of yours in the obfuscated domain.tld:localpart format. Putting ale275 there will make MacPorts think your email address is ale275@macports.org.
• Please decide whether you want to mark the port with the openmaintainer policy; see ​https://guide.macports.org/#project.update-policies.nonmaintainer for an explanation. We don't mind either way, but want it to be a conscious decision, not a silent default.
• Dependencies on openssl should be written path:lib/libssl.dylib:openssl so that libressl can satisfy them, unless you know the port won't build with libressl.
• configure.pre_args already contains --prefix=${prefix}, so can just remove it from configure.args.
• We are trying to get rid of no_* variants and instead prefer positive variants that are enabled by default, e.g.

  variant metadata description {Enable metadata output} {
    configure.args-append --with-metadata
  }
  default_variants +metadata
  

[ctreleaven (Craig Treleaven)]

Also, typically, pkgconfig, autoconf, and automake are only needed at build time and therefore specified with depends_build rather than depends_lib.

[ale275 (Alessandro Gritti)]

Thank you for the suggestions neverpanic this is my first macport. It should be ok now

[neverpanic (Clemens Lang)]

You can remove the name and version fields, github.setup sets them for you.

Your current +metadata variant does not change how the port is built, because --with-metadata is already in the default configure.args.

[neverpanic (Clemens Lang)]

The license field is wrong, too. Looking through the source code, it should be license MIT BSD ISC.

[ale275 (Alessandro Gritti)]

v3 - more fixes

[ale275 (Alessandro Gritti)]

done, sorry for the stupid mistakes

[neverpanic (Clemens Lang)]

In 62fd8da4/macports-ports:

shairport-sync: new port

An AirPlay audio player for multi-room audio.

Submission by maintainer, commited with the following changes:

• Removed $Id$ line, added standard modeline
• Removed configuration file and added a post-activate block to create it if it does not exist to avoid overriding users' configurations on update.

Closes: #52870