mpv @0.20.0_1-network: Configuration fails due to invalid sed expression

[Eitot]

Build configuration fails when variant network is deselected. I presume that the error is caused by this line in the Portfile:

reinplace -W "${worksrcpath}/TOOLS" "|@@NETWORK@@|d" config-maintainer

Replacing the | characters in the expression with something else, e.g. /, seems to work.

Error log:

:debug:configure configure phase started at Mon Nov 14 15:32:39 CET 2016
:notice:configure --->  Configuring mpv
:debug:configure Using compiler 'Xcode Clang'
:debug:configure Executing proc-pre-org.macports.configure-configure-0
:info:configure --->  Patching config-maintainer: |@@NETWORK@@|d
:debug:configure Executing reinplace: /usr/bin/sed |@@NETWORK@@|d < /opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_release_tarballs_ports_multimedia_mpv/mpv/work/mpv-0.20.0/TOOLS/config-maintainer >@ file18 2>@stderr
:debug:configure illegal use of | or |& in command
    while executing
"exec /usr/bin/sed |@@NETWORK@@|d < /opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_release_tarballs_ports_multimedia_..."
    ("eval" body line 1)
    invoked from within
"eval exec $cmdline"
:error:configure reinplace: illegal use of | or |& in command
:error:configure org.macports.configure for port mpv returned: reinplace sed(1) failed
:debug:configure Error code: NONE
:debug:configure Backtrace: reinplace sed(1) failed
    while executing
"proc-pre-org.macports.configure-configure-0 org.macports.configure"
    ("eval" body line 1)
    invoked from within
"eval $pre $targetname"

[raimue (Rainer Müller)]

Indeed, | is special in Tcl's exec and there is no way to escape it (upstream ​TIP#424). You will need to use another separator, common choices would be / or ,.

[Mihai Moldovan <ionic@…>]

In 7f9cb693/macports-ports:

multimedia/mpv: update to 0.22.0. Fixes: #52878 (​https://github.com/macports/macports-ports/pull/52878), fixes: #52845 (​https://github.com/macports/macports-ports/pull/52845)

Changes:

• Refresh 10.6 patchset.
• Drop legacy Id line.
• Move files from ${prefix}/share/examples/mpv to ${prefix}/share/doc/mpv/examples/.
• Disable previous;y missed and new features.
• Add new "zsh" variant for installing zsh completions.
• Reformat notes a bit to remove redundant whitespaces.
• Add comment regarding configure.args and why I cannot use it (yet?)
• Fix @@NETWORK@@ reinplaces.

[Mihai Moldovan <ionic@…>]

In 29fd6b3c/macports-ports:

multimedia/mpv: update to 0.22.0. Fixes: #52878 (​https://github.com/macports/macports-ports/pull/52878), fixes: #52845 (​https://github.com/macports/macports-ports/pull/52845)

Changes:

• Refresh 10.6 patchset.
• Drop legacy Id line.
• Move files from ${prefix}/share/examples/mpv to ${prefix}/share/doc/mpv/examples/.
• Disable previous;y missed and new features.
• Add new "zsh" variant for installing zsh completions.
• Reformat notes a bit to remove redundant whitespaces.
• Add comment regarding configure.args and why I cannot use it (yet?)
• Fix @@NETWORK@@ reinplaces.