Opened 8 years ago

Closed 7 years ago

#52984 closed update (fixed)

Upgrade camlp5 to 6.17

Reported by: pmetzger (Perry E. Metzger) Owned by: larryv (Lawrence Velázquez)
Priority: Normal Milestone:
Component: ports Version: 2.3.5
Keywords: haspatch Cc:
Port: camlp5

Description

Please upgrade camlp5 to 6.17. I've attached a patch.

Attachments (1)

camlp5.patch (1.6 KB) - added by pmetzger (Perry E. Metzger) 8 years ago.
Patch to upgrade the Portfile

Download all attachments as: .zip

Change History (10)

comment:1 Changed 8 years ago by mf2k (Frank Schima)

Notes:

  • Please use the github portgroup. This will simplify the Portfile.
  • The revision line should be deleted because it starts at 0 when increasing the version and that is the default value.

comment:2 Changed 8 years ago by pmetzger (Perry E. Metzger)

I don't know how to use the github portgroup. Can you supply me with information on what to do?

I can easily delete the revision line and update.

Changed 8 years ago by pmetzger (Perry E. Metzger)

Attachment: camlp5.patch added

Patch to upgrade the Portfile

comment:3 Changed 8 years ago by pmetzger (Perry E. Metzger)

Revision line deleted. I still don't know how to use the github portgroup and the documentation file seems a bit silent.

comment:4 Changed 8 years ago by mf2k (Frank Schima)

This website seems to have a good description of using the github portgroup.

comment:5 Changed 8 years ago by pmetzger (Perry E. Metzger)

It's not really that great a description, and in particular doesn't tell me what parts of what I did can be replaced with what -- things like the hack I needed to add to alter the version number to remove the "." still seem to be needed. In fact, it isn't clear what goes away other than the path for the distfile.

If you want to get people to fix portfiles properly, it might be nice if someone (perhaps even you) wrote real docs. I'm also reluctant to make changes here when I don't know what I'm actually doing. If you do, could you supply your changes instead, or documentation?

comment:6 Changed 8 years ago by raimue (Rainer Müller)

The github port group contains documentation in the code. There are also plenty of ports using this port group in the ports tree.

The section on port groups in the guide could include more port groups and there are plenty of open requests: #25170, #32428, #39412. Although, most port groups have good documentation inline, where it is less likely to go out of sync. Contributions to the guide are very welcome, I recently added some docs on how the guide can be updated by anyone.

comment:7 Changed 8 years ago by larryv (Lawrence Velázquez)

Owner: set to larryv
Status: newaccepted

I’ll do this at the same time as #52844.

comment:8 Changed 7 years ago by pmetzger (Perry E. Metzger)

This can now be closed.

comment:9 Changed 7 years ago by neverpanic (Clemens Lang)

Resolution: fixed
Status: acceptedclosed
Note: See TracTickets for help on using tickets.