octave @4.2.0: build failure under Sierra

[Schamschula (Marius Schamschula)]

As I maintain a number of octave packages, I wanted to update my installed version to the new update (4.2.0). Unfortunately, I get a link failure for LAPACK symbols:

:info:build   CXXLD    libinterp/liboctinterp.la
:info:build clang: warning: argument unused during compilation: '-pthread'
:info:build clang: warning: argument unused during compilation: '-pthread'
:info:build Undefined symbols for architecture x86_64:
:info:build   "_ctrsen_", referenced from:
:info:build       Fordschur(octave_value_list const&, int) in libcorefcn.a(libinterp_corefcn_libcorefcn_la-ordschur.o)
:info:build   "_dggbak_", referenced from:
:info:build       Fqz(octave_value_list const&, int) in libcorefcn.a(libinterp_corefcn_libcorefcn_la-qz.o)
:info:build   "_dggbal_", referenced from:
:info:build       Fqz(octave_value_list const&, int) in libcorefcn.a(libinterp_corefcn_libcorefcn_la-qz.o)
:info:build   "_dgghrd_", referenced from:
:info:build       Fqz(octave_value_list const&, int) in libcorefcn.a(libinterp_corefcn_libcorefcn_la-qz.o)
:info:build   "_dhgeqz_", referenced from:
:info:build       Fqz(octave_value_list const&, int) in libcorefcn.a(libinterp_corefcn_libcorefcn_la-qz.o)
:info:build   "_dlag2_", referenced from:
:info:build       Fqz(octave_value_list const&, int) in libcorefcn.a(libinterp_corefcn_libcorefcn_la-qz.o)
:info:build   "_dtgevc_", referenced from:
:info:build       Fqz(octave_value_list const&, int) in libcorefcn.a(libinterp_corefcn_libcorefcn_la-qz.o)
:info:build   "_dtrsen_", referenced from:
:info:build       Fordschur(octave_value_list const&, int) in libcorefcn.a(libinterp_corefcn_libcorefcn_la-ordschur.o)
:info:build   "_strsen_", referenced from:
:info:build       Fordschur(octave_value_list const&, int) in libcorefcn.a(libinterp_corefcn_libcorefcn_la-ordschur.o)
:info:build   "_zggbak_", referenced from:
:info:build       Fqz(octave_value_list const&, int) in libcorefcn.a(libinterp_corefcn_libcorefcn_la-qz.o)
:info:build   "_zggbal_", referenced from:
:info:build       Fqz(octave_value_list const&, int) in libcorefcn.a(libinterp_corefcn_libcorefcn_la-qz.o)
:info:build   "_zgghrd_", referenced from:
:info:build       Fqz(octave_value_list const&, int) in libcorefcn.a(libinterp_corefcn_libcorefcn_la-qz.o)
:info:build   "_zhgeqz_", referenced from:
:info:build       Fqz(octave_value_list const&, int) in libcorefcn.a(libinterp_corefcn_libcorefcn_la-qz.o)
:info:build   "_ztgevc_", referenced from:
:info:build       Fqz(octave_value_list const&, int) in libcorefcn.a(libinterp_corefcn_libcorefcn_la-qz.o)
:info:build   "_ztrsen_", referenced from:
:info:build       Fordschur(octave_value_list const&, int) in libcorefcn.a(libinterp_corefcn_libcorefcn_la-ordschur.o)
:info:build ld: symbol(s) not found for architecture x86_64

Tis occurred both while upgrading my current configuration:

i.e. octave +app+atlas+docs+fltk+gfortran+graphicsmagick+java+qt4gui+sound

and the default

i.e. octave +accelerate+app+docs+fltk+gfortran+graphicsmagick+java+qt4gui+sound

I've attached the log file from the second build. The errors are identical in both cases.

[Schamschula (Marius Schamschula)]

Don't you love autofill...

[MarcusCalhoun-Lopez (Marcus Calhoun-Lopez)]

As a leftover from octave-devel, patch-qscintilla2.diff accidentally patches m4/acinclude.m4 instead of configure.
This causes /bin/sh ./config.status --recheck to rerun configure in the build phase.

[MarcusCalhoun-Lopez (Marcus Calhoun-Lopez)]

In a43dddb7/macports-ports:

octave: replace patch from octave-devel with correct patch

A revbump is required since an incorrect build might be possible with
a certain combinations of variants.

Fixes #53010