Opened 8 years ago

Closed 6 years ago

#53087 closed enhancement (fixed)

ntp @4.2.8p9: libressl compatibility patch

Reported by: jerryyhom Owned by:
Priority: Normal Milestone:
Component: ports Version:
Keywords: haspatch Cc: dluke@…
Port: ntp

Description

Version 4.2.8p9 uses newer OpenSSL 1.1 APIs but also has backwards compatibility with older OpenSSL. If building with LibreSSL, must specify to use older APIs.

Attachments (2)

patch-libressl-compat.diff (949 bytes) - added by jerryyhom 8 years ago.
Portfile-ntp.diff (535 bytes) - added by jerryyhom 8 years ago.

Download all attachments as: .zip

Change History (9)

Changed 8 years ago by jerryyhom

Attachment: patch-libressl-compat.diff added

Changed 8 years ago by jerryyhom

Attachment: Portfile-ntp.diff added

comment:1 Changed 8 years ago by danielluke (Daniel J. Luke)

Have you pushed this patch back upstream too?

If it's accepted upstream, I'd be inclined to include it - but otherwise, I'd be more inclined to just switch to port:openssl style-dependency.

comment:2 Changed 8 years ago by jerryyhom

Oh, good point. Hm, I was just following the style of #53017, but it's up to you.

Last edited 7 years ago by ryandesign (Ryan Carsten Schmidt) (previous) (diff)

comment:3 in reply to:  2 Changed 8 years ago by danielluke (Daniel J. Luke)

Replying to jerryyhom:

I was just following the style of #53017, but it's up to you.

It's totally valid, I'd just like to see it submitted upstream as well (so everyone, not just MacPorts users, can benefit).

Last edited 7 years ago by ryandesign (Ryan Carsten Schmidt) (previous) (diff)

comment:4 Changed 8 years ago by jerryyhom

Well, NTP seems to be refusing bug/patch reports from outsiders, or their email system is on lockdown. If you have a bug account with NTP, I suggest you submit the patch.

comment:5 Changed 7 years ago by janstary (Jan Starý)

ntp builds fine without patches in https://github.com/macports/macports-ports/pull/1626

comment:6 Changed 6 years ago by jerryyhom

Hm, I did not receive an email update on this ticket and nearly forgot about it, but this ticket can and should be closed. Since libressl 2.7, this issue has been resolved, and the patch is no longer needed.

comment:7 Changed 6 years ago by mf2k (Frank Schima)

Resolution: fixed
Status: newclosed
Type: updateenhancement
Version: 2.3.5
Note: See TracTickets for help on using tickets.