Opened 8 years ago

Closed 8 years ago

Last modified 8 years ago

#53113 closed defect (fixed)

options set from the command line have incorrect extra quotes added

Reported by: ryandesign (Ryan Carsten Schmidt) Owned by: jmroot (Joshua Root)
Priority: Normal Milestone:
Component: base Version: 2.3.99
Keywords: Cc: kurthindenburg (Kurt Hindenburg), jmroot (Joshua Root)
Port:

Description

I used to be able to disable ccache for a single port build by adding configure.ccache=no to the command line invocation, but with the latest base code I now get an error:

sudo port -s install php53-vld configure.ccache=no
--->  Cleaning php53-vld
--->  Computing dependencies for php53-vld
Error: expected boolean value but got ""no""
Error: See /opt/local/var/macports/logs/_Users_rschmidt_macports_macports-ports_php_php-vld/php53-vld/main.log for details.
Error: Follow https://guide.macports.org/#project.tickets to report a bug.
Error: Processing of port php53-vld failed

Change History (5)

comment:1 Changed 8 years ago by ryandesign (Ryan Carsten Schmidt)

Similar problem reported for inability to set configure.compiler on the command line in #53157.

comment:2 Changed 8 years ago by kurthindenburg (Kurt Hindenburg)

Cc: khindenburg jmroot added

From what I gather using git bisect, this was the commit

commit 59bceb47a4eb7ce3e354069220fbbaeba7544cf3
Author: Joshua Root <jmr@macports.org>
Date:   Wed Nov 30 08:59:01 2016 +1100

    improve quoting of 'interp eval' args

    Having a single argument, preferably braced to guarantee that no
    substitution will happen, reduces the amount of string processing
    and may enable byte compilation in some cases.

comment:3 Changed 8 years ago by jmroot (Joshua Root)

Summary: expected boolean value but got ""no""options set from the command line have incorrect extra quotes added

comment:4 Changed 8 years ago by jmroot (Joshua Root)

Owner: set to jmroot
Resolution: fixed
Status: newclosed

In 06daa26/macports-base:

Don't overquote values of command line options

This was previously needed because they were not correctly quoted when used
elsewhere, but that was fixed.

Fixes: #53113

comment:5 Changed 8 years ago by jmroot (Joshua Root)

Cc: kurthindenburg added; khindenburg removed
Note: See TracTickets for help on using tickets.