#53136 closed enhancement (fixed)
emacs 25.1: add modules variant to build with loadable module support
| Reported by: | little-big-h | Owned by: | drkp (Dan Ports) |
|---|---|---|---|
| Priority: | Normal | Milestone: | |
| Component: | ports | Version: | |
| Keywords: | haspatch | Cc: | |
| Port: | emacs |
Description
Emacs allows loadable modules with version 25.1. However, this functionality needs to be enabled at build-time. This variant enables loadable module support and installs the header necessary for building modules.
Attachments (1)
Change History (6)
Changed 8 years ago by little-big-h
| Attachment: | Portfile-emacs.diff added |
|---|
comment:1 Changed 8 years ago by mf2k (Frank Schima)
| Cc: | drkp removed |
|---|---|
| Keywords: | haspatch added; modules removed |
| Owner: | set to drkp |
| Status: | new → assigned |
comment:2 Changed 8 years ago by drkp (Dan Ports)
| Status: | assigned → accepted |
|---|
comment:3 Changed 8 years ago by little-big-h
Excellent question. I've been thinking about this myself: The emacs-folks chose to disable dynamic modules by default and I just went along. I couldn't find any discussion or justification online but my gut tells me rms is somehow behind this :-) - I think he's not happy about having modules in there in the first place.
I guess you could just enable it by default. I suspect it will become the default eventually and the patch will be unnecessary.
comment:4 Changed 8 years ago by drkp (Dan Ports)
| Resolution: | → fixed |
|---|---|
| Status: | accepted → closed |
comment:5 Changed 8 years ago by drkp (Dan Ports)
If rms is unhappy about it, that's good enough for me. :-)
Enabled it by default. Note that only the emacs ports (not emacs-app) install the header file. This is to keep them from conflicting with each other.
Thanks for the patch! Any downsides to just having this enabled all the time, instead of making it a variant? We might as well cut down on the number of variants.