libuv @1.10.1 does not build on PPC Tiger, Mac OS X

[ballapete (Peter "Pete" Dyballa)]

src/unix/fs.c uses unknown struct members, dst->st_birthtim.tv_sec and dst->st_birthtim.tv_nsec, and src/unix/tty.c uses an unknown macro TIOCPTYGNAME. These and can easily be fixed with the provided patch files.

src/unix/fsevents.c is a bit harder to fix. It includes /System/Library/Frameworks/CoreServices.framework/Frameworks/OSServices.framework/Headers/OpenTransportProviders.h, which has

/* TCP Level Options*/

enum {
  TCP_NODELAY                   = 0x01, 
  TCP_MAXSEG                    = 0x02, 
  TCP_NOTIFY_THRESHOLD          = 0x10, /** not a real XTI option */
  TCP_ABORT_THRESHOLD           = 0x11, /** not a real XTI option */
  TCP_CONN_NOTIFY_THRESHOLD     = 0x12, /** not a real XTI option */
  TCP_CONN_ABORT_THRESHOLD      = 0x13, /** not a real XTI option */
  TCP_OOBINLINE                 = 0x14, /** not a real XTI option */
  TCP_URGENT_PTR_TYPE           = 0x15, /** not a real XTI option */
  TCP_KEEPALIVE                 = 0x0008 /* keepalive defined in OpenTransport.h */
};

The C pre-processor generates

enum {
  0x01 = 0x01, 
  0x02 = 0x02, 
  TCP_NOTIFY_THRESHOLD = 0x10, 
  TCP_ABORT_THRESHOLD = 0x11, 
  TCP_CONN_NOTIFY_THRESHOLD = 0x12, 
  TCP_CONN_ABORT_THRESHOLD = 0x13, 
  TCP_OOBINLINE = 0x14, 
  TCP_URGENT_PTR_TYPE = 0x15, 
  0x10 = 0x0008
};

which of course leads to an error:

In /System/Library/Frameworks/CoreServices.framework/Frameworks/OSServices.framework/Headers/OpenTransportProviders.h:108: error: expected identifier before numeric constant

The reason for is presumingly /usr/include/netinet/tcp.h:

#ifndef _NETINET_TCP_H_
#define _NETINET_TCP_H_
.
.
.
/*
 * User-settable options (used with setsockopt).
 */
#define TCP_NODELAY     0x01    /* don't delay send to coalesce packets */
#ifndef _POSIX_C_SOURCE
#define TCP_MAXSEG              0x02    /* set maximum segment size */ 
#define TCP_NOPUSH              0x04    /* don't push last block of write */
#define TCP_NOOPT               0x08    /* don't use TCP options */
#define TCP_KEEPALIVE   0x10    /* idle time used when SO_KEEPALIVE is enabled */
#endif /* _POSIX_C_SOURCE */

#endif

For this I cannot imagine a fix…

[ballapete (Peter "Pete" Dyballa)]

main.log with st_birthtim.tv error

[ballapete (Peter "Pete" Dyballa)]

main.log with the enum bug

[ballapete (Peter "Pete" Dyballa)]

Patch to delete st_birthtim.tv_*

[ballapete (Peter "Pete" Dyballa)]

Patch to delete TIOCPTYGNAME

[mf2k (Frank Schima)]

In the future, please Cc the port maintainers (port info --maintainers libuv), if any.

[ballapete (Peter "Pete" Dyballa)]

Replying to mf2k:

In the future, please Cc the port maintainers (port info --maintainers libuv), if any.

This was my first try *not* to add the maintainer(s), since I've seen so often that my additions were removed later. And the look, which is not available in Tiger, does not have a maintainer field, just a watcher (?) field. And I learned that I have to my own name there when I want to receive eMails about thing that happen to my report.

OK, I'll continue adding watchers!

[kencu (Ken)]

Although you are completely correct in pointing out the libuv @1.10.1 does not build on Tiger (at least at this moment -- these things usually have a way of working out in the end), I might guess that the reason you now need libuv is because of the change in cmake-3.7.1; the portfile now specifies the system-library versions of most libraries, one of which is libuv.

Cmake also includes it's own versions of the needed system libraries, however, and these internal versions still build on Tiger (go figure).

So one way around your libuv issue is to edit the cmake portflle, remove the requirement for libuv by commenting it out like this:

#depends_lib-append  path:lib/pkgconfig/libuv.pc:libuv

and change the following configure arguments from this:

--init=${worksrcpath}/macports.cmake \
--system-libs \
 --no-system-jsoncpp

to this

--init=${worksrcpath}/macports.cmake

then, when upgrading cmake, the system libuv is not required, and cmake 3.7.1 builds through to completion on Tiger without trouble.

$ port -v installed | grep cmake
 cmake @3.6.3_0 platform='darwin 8' archs='ppc'
 cmake @3.7.1_0 (active) platform='darwin 8' archs='ppc'

if you actually needed libuv for some other reason besides cmake - well, obviously this won't help you. K.

[ballapete (Peter "Pete" Dyballa)]

Replying to kencu:

So one way around your libuv issue is to edit the cmake portflle, remove the requirement for libuv by commenting it out like this:

Presumingly next week I can try… Now GCC6 is building – for days!

if you actually needed libuv for some other reason besides cmake - well, obviously this won't help you. K.

For decades (1¼?) I could live on Tiger without libuv. I am willing to continue…

Thanks for the information!

[raimue (Rainer Müller)]

As Mac OS X 10.4 Tiger is a legacy platform and over 10 years old, I will not investigate myself or take action to fix this. Patches are welcome, but please also include the necessary changes to the Portfile. I do not know and cannot test whether this affects specifically only Mac OS X 10.4 Tiger and no later version, or only PPC, etc.

You could also get help with this by contacting ​upstream and maybe even incorporate the patches there directly.

[kencu (Ken)]

This port does build on both 10.5 PPC and 10.5 Intel, and up. The issues with it building on 10.4 PPC are probably something that could be overcome (usually these things are POSIX define mixups on 10.4 -- this didn't really get straightened out until 10.5).

As there is no real need for libuv at the moment other than Cmake (which has a good workaround as above) I don't imagine I'll be spending any time on this to fix it.

So as far as I'm personally concerned, this could be closed as 'wontfix'.

I'll pass along the cmake tiger fix to michael and see what he thinks about incorporating it into macports. For the moment, it sits in my custom TigerPorts repo at <​https://github.com/kencu/TigerPorts> for anyone who might want it (along with lots of other Tiger fixes).

[mojca (Mojca Miklavec)]

I wouldn't necessarily bother fixing libuv, but it would make sense to fix cmake in a way that it would use the internal library rather than the external one if that helps. That should be easy enough to do and it affects a lot of ports (the system without cmake is nearly useless).

[kencu (Ken)]

this works in the cmake portfile

platform darwin 8 {
    configure.args-delete --system-libs \
                          --no-system-jsoncpp
    depends_lib-delete    path:lib/pkgconfig/libuv.pc:libuv
}

[kencu (Ken)]

a patch for cmake-371 for tiger to disable need for libuv

[michaelld (Michael Dickens)]

In 1d68d187/macports-ports:

cmake: on Tiger (10.4), just use cmake internal system libraries, since those provided by the system and/or macPorts do not build or work as desired. Partly addresses ticket #53143 .

[michaelld (Michael Dickens)]

I've integrated Ken's patch. Does that fix this ticket?

[ballapete (Peter "Pete" Dyballa)]

Replying to raimue:

You could also get help with this by contacting ​upstream and maybe even incorporate the patches there directly.

This is not easy … GitHub does not accept old Safaris.

[ballapete (Peter "Pete" Dyballa)]

Replying to michaelld:

I've integrated Ken's patch. Does that fix this ticket?

Libuv now is not listed as being outdated. So the cmake port is fixed.

[kencu (Ken)]

Replying to ballapete:

This is not easy … GitHub does not accept old Safaris.

Use TenFourFox <​http://www.floodgap.com/software/tenfourfox/> for a reasonably current browser for PPC 10.4 and 10.5

[michaelld (Michael Dickens)]

So ... does fixing cmake address the needs of this ticket?

[raimue (Rainer Müller)]

I guess libuv is still broken on 10.4, but the original goal of the reporter to get cmake was fulfilled. If nobody is going to provide a proper patch against libuv, I would close this as a wontfix.

[michaelld (Michael Dickens)]

Sounds good. Thx.

[ballapete (Peter "Pete" Dyballa)]

Replying to kencu:

Use TenFourFox <​http://www.floodgap.com/software/tenfourfox/> for a reasonably current browser for PPC 10.4 and 10.5

Yeah, it's quite slow, but it works with GitHub and even Macports!

[ballapete (Peter "Pete" Dyballa)]

Replying to raimue:

You could also get help with this by contacting ​upstream and maybe even incorporate the patches there directly.

I have the feeling that before TenFourFox had refreshed the window of issue ​https://github.com/libuv/libuv/issues/1180 someone had responded with: 10.4 is not supported. Please see https://github.com/libuv/libuv/blob/v1.x/SUPPORTED_PLATFORMS.md.

[ballapete (Peter "Pete" Dyballa)]

Replying to raimue:

I guess libuv is still broken on 10.4, but the original goal of the reporter to get cmake was fulfilled. If nobody is going to provide a proper patch against libuv, I would close this as a wontfix.

I thinks that's correct. In reporting the issue on GitHub it looks as if Tiger is missing some newer system APIs, for example FSEventStreamRef.

[kencu (Ken)]

You can prevent including /usr/include/netinet/tcp.h by defining the header blocker in the Portfile:

configure.cppflags-append -D_NETINET_TCP_H_

This gets around the first error of the error: expected identifier before numeric constant issue.

That then leads to some other errors, though:

src/unix/fs.c:574: warning: implicit declaration of function 'sendfile'
src/unix/fs.c: In function 'uv__to_stat':
src/unix/fs.c:711: error: 'struct stat' has no member named 'st_birthtimespec'

[ballapete (Peter "Pete" Dyballa)]

Since libuv @1.24.0_0 (active) platform='darwin 8' archs='ppc' date='2018-11-15T01:12:55+0100' could be built (and installed), this case can be closed.