Opened 8 years ago

Closed 3 years ago

#53156 closed update (fixed)

upgrade: port:Vc

Reported by: RJVB (René Bertin) Owned by: RJVB (René Bertin)
Priority: Normal Milestone:
Component: ports Version:
Keywords: haspatch maintainer Cc: chrstphrchvz (Christopher Chavez)
Port: Vc

Description

port:Vc has been upgraded; the attached patch brings it to 1.3.0.14 to get as much support as possible for the latest CPU models.

It also uses the Ninja generator from the cmake-1.1 PortGroup, to reduce build resource requires a bit.

Attachments (2)

Vc.diff​ (3.3 KB) - added by RJVB (René Bertin) 8 years ago.
Vc.2.diff​ (3.3 KB) - added by RJVB (René Bertin) 8 years ago.
upgrade and drop the installs_libs=no declaration

Download all attachments as: .zip

Change History (17)

Changed 8 years ago by RJVB (René Bertin)

Attachment: Vc.diff​ added

comment:1 Changed 8 years ago by mkae (Marko Käning)

Cc: mkae added; RJVB removed

comment:2 Changed 8 years ago by ryandesign (Ryan Carsten Schmidt)

A static library is still a library, isn't it?

comment:3 Changed 8 years ago by RJVB (René Bertin)

True, so since you raise the point: what exactly is the variable used for?

comment:4 Changed 8 years ago by mkae (Marko Käning)

Is this about 

installs_libs       no

?

comment:5 Changed 8 years ago by RJVB (René Bertin)

yes

comment:6 Changed 8 years ago by ryandesign (Ryan Carsten Schmidt)

The installs_libs variable indicates whether the port installs any libraries. Since this port does, it should not claim installs_libs no.

comment:7 Changed 8 years ago by RJVB (René Bertin)

OK, but that doesn't answer the question what the information is used for.

Changed 8 years ago by RJVB (René Bertin)

Attachment: Vc.2.diff​ added

upgrade and drop the installs_libs=no declaration

comment:8 Changed 8 years ago by mkae (Marko Käning)

Cc: mkae removed
Owner: set to mkae
Status: new → accepted

comment:9 Changed 8 years ago by mkae (Marko Käning)

@rjvb, I get it that this update of the Vc port needs ​PR #26...

Last edited 8 years ago by mkae (Marko Käning) (previous) (diff)

comment:10 Changed 8 years ago by RJVB (René Bertin)

I think I may have been using new stuff from that PG, indeed :)

You were looking for test-cases, no? ...

comment:11 Changed 7 years ago by mf2k (Frank Schima)

Keywords: maintainer added
Owner: changed from mkae to RJVB
Status: accepted → assigned

comment:12 Changed 7 years ago by pmetzger (Perry E. Metzger)

Howdy! Do you think you could redo this as a github pull request? It will be acted on faster that way.

comment:13 Changed 6 years ago by chrstphrchvz (Christopher Chavez)

This port has since been updated to 1.4.1 (currently the latest version). I believe this ticket can be closed.

comment:14 Changed 6 years ago by chrstphrchvz (Christopher Chavez)

Cc: chrstphrchvz added

comment:15 Changed 3 years ago by reneeotten (Renee Otten)

Resolution: → fixed
Status: assigned → closed
Note: See TracTickets for help on using tickets.