Opened 8 years ago

Closed 8 years ago

#53218 closed enhancement (wontfix)

slrn: new pull_ssl variant

Reported by: niemda (niemda) Owned by: olaf@…
Priority: Normal Milestone:
Component: ports Version:
Keywords: haspatch Cc:
Port: slrn

Description

I propose new variant for slrn port which combines existing +ssl and +pull, because existing +pull lacks ssl support. Proposed change to the portfile is:

--- Portfile	2017-01-05 17:04:22.000000000 +0500
+++ /opt/local/var/macports/sources/rsync.macports.org/release/tarballs/ports/news/slrn/Portfile	2017-01-02 05:55:32.000000000 +0500
@@ -34,14 +34,6 @@
 			depends_lib-append	path:lib/libssl.dylib:openssl
 }
 
-# pull_ssl variant
-variant pull_ssl {
-      configure.args-append   --with-slrnpull
-			configure.args-append 	--with-ssl=${prefix} \
-						--with-ssl-includes=${prefix}/include/openssl
-			depends_lib-append	path:lib/libssl.dylib:openssl
-}
-
 variant uudeview description {Use uudeview library to decode uuencoded articles} {
 	# build dependency because uudeview provides only the static library libuu.a
 	depends_build-append	port:uudeview

I am testing slrn built with these options now. My personal preference is to make ssl default option of the port, but this simple change doesn't look very disruptive.

Attachments (1)

Portfile.slrn.patch (707 bytes) - added by niemda (niemda) 8 years ago.
Patch for slrn Portfile

Download all attachments as: .zip

Change History (4)

Changed 8 years ago by niemda (niemda)

Attachment: Portfile.slrn.patch added

Patch for slrn Portfile

comment:1 Changed 8 years ago by ryandesign (Ryan Carsten Schmidt)

Keywords: haspatch added; port variant proposal removed
Milestone: MacPorts Future
Owner: set to olaf@…
Priority: LowNormal
Status: newassigned
Summary: Proposal: New variant for slrn portslrn: new pull_ssl variant

Your patch is reversed.

Why would we need a new pull_ssl variant? Why can't you just install the port with both of the existing variants together, which should accomplish the same thing?

sudo port install slrn +pull +ssl

comment:2 Changed 8 years ago by niemda (niemda)

Yes, did clean and tried installing +pull +ssl again. It worked. I wonder why it doesn't first time. OK, no need to change anything.

comment:3 Changed 8 years ago by mf2k (Frank Schima)

Resolution: wontfix
Status: assignedclosed
Note: See TracTickets for help on using tickets.