R 3.3.2 fails to build due to zlib not being present

[Morpheu5 (Andrea Franceschini)]

Like it says, see main.log attached.

[Morpheu5 (Andrea Franceschini)]

main.log

[Morpheu5 (Andrea Franceschini)]

Forgot to mention, this happens on macOS 10.12.2. I did the proper migration procedure, and pretty much every other package compiled fine – except for ghc, which I have patched.

[mf2k (Frank Schima)]

In the future, please Cc the port maintainers (port info --maintainers R), if any.

[Morpheu5 (Andrea Franceschini)]

Replying to mf2k:

In the future, please Cc the port maintainers (port info --maintainers R), if any.

Thanks, I was in a rush, I forgot a lot of stuff :(

[kjellpk (Kjell Konis)]

Maintainer here. Funnily enough I also just upgraded to 10.12.2 (from El Cap) and ran into exactly the same problem. But that doesn't have anything to do with this bug.

R's configure script uses this program to check the version of zlib:

#include <stdlib.h>
#include <string.h>
#include <zlib.h>
int main() {
#ifdef ZLIB_VERSION
/* Work around Debian bug: it uses 1.2.3.4 even though there was no such
   version on the master site zlib.net */
  exit(strncmp(ZLIB_VERSION, "1.2.5", 5) < 0);
#else
  exit(1);
#endif
}

which reads the current version of zlib (1.2.10) as 1.2.1 and ranks it less than 1.2.5. I made the following change

#include <stdlib.h>
#include <string.h>
#include <zlib.h>
int main() {
#ifdef ZLIB_VERSION
  if(strlen(ZLIB_VERSION) == 6) exit(strncmp(ZLIB_VERSION, "1.2.05", 6) < 0);
/* Work around Debian bug: it uses 1.2.3.4 even though there was no such
   version on the master site zlib.net */
  exit(strncmp(ZLIB_VERSION, "1.2.5", 5) < 0);
#else
  exit(1);
#endif
}

which fixes the problem for me (and hopefully won't introduce a bug for anyone else). The attached R-Portfile.diff makes this change and also removes the no longer used --with-system-zlib from the configure arguments.

[Morpheu5 (Andrea Franceschini)]

Thanks, your changes fixed the problem for me too.

[mf2k (Frank Schima)]

Thank you. Since it is a build issue, there is no need to increase the revision.

[gaming-hacker (G Alexander)]

good fix, works for me, i just updated from 10.11.6 to 10.12.2

[kjellpk (Kjell Konis)]

Maintainer here. I just attached a new diff that doesn't bump the revision. Please commit asap.

[ryandesign (Ryan Carsten Schmidt)]

Has duplicate #53288.

[ryandesign (Ryan Carsten Schmidt)]

In fa76739d/macports-ports:

R: Remove unneeded --with-system-zlib flag

See: #53228

[ryandesign (Ryan Carsten Schmidt)]

In efbf387e/macports-ports:

R: Fix incorrect zlib version comparison

Closes: #53228