Opened 8 years ago

Closed 8 years ago

Last modified 8 years ago

#53243 closed enhancement (fixed)

Add Python 3.6 to py-readline

Reported by: radarhere (Andrew Murray) Owned by: ryandesign (Ryan Carsten Schmidt)
Priority: Normal Milestone:
Component: ports Version: 2.3.5
Keywords: haspatch Cc: fhgwright (Fred Wright), larryv (Lawrence Velázquez), nhojpatrick (John Patrick), jyrkiwahlstedt, kundor (Nicholas Matteo), rogererens (Roger Erens), akkornel (A. Karl Kornel)
Port: py-readline

Description


Attachments (1)

Portfile-py-readline.diff​ (288 bytes) - added by radarhere (Andrew Murray) 8 years ago.

Download all attachments as: .zip

Change History (9)

Changed 8 years ago by radarhere (Andrew Murray)

Attachment: Portfile-py-readline.diff​ added

comment:1 Changed 8 years ago by ryandesign (Ryan Carsten Schmidt)

Cc: fhgwright larryv nhojpatrick jyrkiwahlstedt kundor added
Owner: set to ryandesign
Status: new → accepted

Supersedes #52558 and #52637.

comment:2 Changed 8 years ago by ryandesign (Ryan Carsten Schmidt)

Resolution: → fixed
Status: accepted → closed

In 50852460/macports-ports:

py-readline: Add py36-readline subport

Closes: #53243

comment:3 Changed 8 years ago by jmroot (Joshua Root)

Are you aware that this doesn't actually work?

​https://github.com/ludwigschwardt/python-gnureadline/issues/50

Also, this readline module hasn't been updated since 2012, because it was renamed gnureadline upstream, as noted on its pypi page: ​https://pypi.python.org/pypi/readline

comment:4 Changed 8 years ago by ryandesign (Ryan Carsten Schmidt)

No, I wasn't aware of those things.

I guess then py-readline and its subports should be replaced_by the corresponding subports of py-gnureadline?

comment:5 Changed 8 years ago by cdeil (Christoph Deil)

After installing this I get a crash: ​https://gist.github.com/cdeil/0e1c9ba2e70ee6cfdbd2434fdcc4cc65

Probably for now py-readline should be kept, because at least on Python <= 3.5 it can be used to solve this issue ​https://trac.macports.org/ticket/48807#comment:100 which as far as I see py-gnureadline can't.

comment:6 Changed 8 years ago by rogererens (Roger Erens)

Cc: rogererens added

comment:7 Changed 8 years ago by radarhere (Andrew Murray)

Since this crashes, I've created #53360 to remove the Python 3.6 subport.

comment:8 Changed 8 years ago by akkornel (A. Karl Kornel)

Cc: akkornel added
Note: See TracTickets for help on using tickets.