dask or scikit-image: add toolz as dependency?

[cdeil (Christoph Deil)]

This is a question, not really a defect.

When I run the py-scikit-image @0.12.3_1 tests I get a few fails from dask because toolz isn't installed. Here's one:

======================================================================
ERROR: skimage.util.tests.test_apply_parallel.test_apply_parallel
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/opt/local/Library/Frameworks/Python.framework/Versions/3.5/lib/python3.5/site-packages/nose/case.py", line 198, in runTest
    self.test(*self.arg)
  File "/opt/local/Library/Frameworks/Python.framework/Versions/3.5/lib/python3.5/site-packages/skimage/util/tests/test_apply_parallel.py", line 18, in test_apply_parallel
    extra_keywords={'mode': 'reflect'})
  File "/opt/local/Library/Frameworks/Python.framework/Versions/3.5/lib/python3.5/site-packages/skimage/util/apply_parallel.py", line 85, in apply_parallel
    import dask.array as da
  File "/opt/local/Library/Frameworks/Python.framework/Versions/3.5/lib/python3.5/site-packages/dask/__init__.py", line 5, in <module>
    from .async import get_sync as get
  File "/opt/local/Library/Frameworks/Python.framework/Versions/3.5/lib/python3.5/site-packages/dask/async.py", line 120, in <module>
    from toolz import identity
ImportError: No module named 'toolz'

Should dask (or scikit-image) have toolz as a dependency?

At ​https://github.com/dask/dask/blob/master/setup.py#L13 I see that dask lists

extras_require = {
  'array': ['numpy', 'toolz >= 0.7.2'],
  'bag': ['cloudpickle >= 0.2.1', 'toolz >= 0.7.2', 'partd >= 0.3.7'],
  'dataframe': ['numpy', 'pandas >= 0.18.0', 'toolz >= 0.7.2',
                'partd >= 0.3.7', 'cloudpickle >= 0.2.1'],
  'distributed': ['distributed >= 1.15', 's3fs >= 0.0.8'],
  'imperative': ['toolz >= 0.7.2'],
}

and at ​https://github.com/conda-forge/dask-feedstock/blob/master/recipe/meta.yaml (written by the dask devs) I see this:

requirements:
  build:
    - python
    - setuptools

  run:
    - python
    - bokeh
    - cloudpickle >=0.2.1
    - numpy
    - pandas >=0.18.0
    - partd >=0.3.6
    - toolz >=0.7.2

?

[jmroot (Joshua Root)]

[b4fe26fb612531c557cdd8926bca747dde91fbda/macports-ports]