Opened 8 years ago
Last modified 4 years ago
#53374 assigned enhancement
Py-Pillow should have tkinter, and webp (or x11) variants
| Reported by: | dmarteau (David Marteau) | Owned by: | stromnov (Andrey Stromnov) |
|---|---|---|---|
| Priority: | Normal | Milestone: | |
| Component: | ports | Version: | |
| Keywords: | haspatch | Cc: | danchr (Dan Villiom Podlaski Christiansen) |
| Port: | py-Pillow |
Description
tkinter and webp are required by pillow dependencies: they depends on X11 and thus pillow installation does not follow -x11 variant rules. I suggest either to follow -x11/no-x11 variants by not including webp and tkinter dependencies or add specific variants for tkinter and webp.
Thx.
Attachments (1)
Change History (15)
comment:1 Changed 8 years ago by mf2k (Frank Schima)
| Cc: | stromnov@… removed |
|---|---|
| Keywords: | haspatch added |
| Owner: | set to stromnov |
| Status: | new → assigned |
| Version: | 2.3.5 |
comment:2 Changed 8 years ago by dmarteau (David Marteau)
The proposed patch set them as default variants
comment:6 Changed 8 years ago by jmroot (Joshua Root)
Just adding and removing dependencies is not enough to make it use those dependencies or not. Also, x11 is a really bad name for a variant that adds webp. (And hopefully the x11 dependency can be removed from webp).
comment:7 Changed 8 years ago by dmarteau (David Marteau)
Actually webp has no variants for removing x11 dependencies: what is your suggestion ?
comment:8 Changed 8 years ago by mf2k (Frank Schima)
Usually such a thing can be specified with a configure argument.
comment:9 Changed 8 years ago by dmarteau (David Marteau)
oh, you mean that we should patch the webp Portfile to accept the x11 variant ?
Changed 8 years ago by dmarteau (David Marteau)
| Attachment: | Portfile-variants.diff added |
|---|
Portfile with tkinter variants
comment:11 Changed 8 years ago by dmarteau (David Marteau)
Added new patchfile with only tkinter variant: let webp package deal with -x11 variant in #53382
comment:12 Changed 4 years ago by danchr (Dan Villiom Podlaski Christiansen)
I noticed an issue related to this one: When Pillow is built against a Tk using X11 as a backend, it'll get a dependency on libxcb. The +quartz variant of tk, however, has no such dependency. As a result, the archives for py-pillow are broken against such a Tk. I posted a pull request to address this:
comment:13 Changed 4 years ago by danchr (Dan Villiom Podlaski Christiansen)
| Cc: | danchr added |
|---|
Maybe make them default variants.