Opened 8 years ago

Closed 7 years ago

#53388 closed enhancement (fixed)

mention bot for GitHub PRs

Reported by: l2dy (Zero King) Owned by: admin@…
Priority: Normal Milestone:
Component: server/hosting Version:
Keywords: Cc: mkae (Marko Käning), mojca (Mojca Miklavec), raimue (Rainer Müller)
Port:

Description

It's hard to manually mention the maintainer on GitHub as one have to find the right GitHub handle on Trac first.

A bot mentioning (@) the maintainer in a comment for every PR would be great.

Change History (6)

comment:1 Changed 8 years ago by mkae (Marko Käning)

Cc: mkae added

comment:2 Changed 8 years ago by mojca (Mojca Miklavec)

Cc: mojca added

comment:3 Changed 8 years ago by raimue (Rainer Müller)

Cc: raimue added

That depends on getting the GitHub names of maintainers into Portfiles first, for which syntax was added in 2.3.5, but it still had some bugs breaking the 'port info' output. Should be safe to use after 2.4.0.

I would prefer to avoid the noise of mentions by requesting them as reviewers, which is a feature GitHub added lately.

comment:4 Changed 8 years ago by mojca (Mojca Miklavec)

We need a couple of things anyway:

  • probably start with the database of users in Trac
  • create a mass update that will change maintainers in all ports at the same time (else this will literally take forever to do manually)
  • figure out how to implement a bot that does something with PRs

Whether to do what l2dy or raimue suggest is not too important. We could even do both as:

  • I can imagine that quite a number of maintainers don't have a GitHub account yet (these might be stale developers anyway, but ...)
  • I would often want to ask specific developers for review even if they are not maintainers of the port in question

so the mapping between maintainers and reviewers would not always be 1:1.

Even if we assign reviewers (which makes sense) I wouldn't mind having a small table listing maintainers with both macports handle & github mention.

comment:5 Changed 8 years ago by l2dy (Zero King)

I do prefer review requests now. I first asked about this in October last year and review requests were introduced in December.

https://lists.macports.org/pipermail/macports-dev/2016-October/034408.html

https://github.com/blog/2291-introducing-review-requests

Last edited 8 years ago by l2dy (Zero King) (previous) (diff)

comment:6 Changed 7 years ago by raimue (Rainer Müller)

Resolution: fixed
Status: newclosed

I guess this should be considered fixed with the PR bot.

Note: See TracTickets for help on using tickets.