#53424 closed submission (fixed)
hstr @1.21 : Bash and Zsh shell history suggest box
Reported by: | 1-61803 | Owned by: | mf2k (Frank Schima) |
---|---|---|---|
Priority: | Normal | Milestone: | |
Component: | ports | Version: | 2.3.5 |
Keywords: | Cc: | ||
Port: | hstr |
Description
Attachments (2)
Change History (9)
Changed 8 years ago by 1-61803
comment:1 Changed 8 years ago by mf2k (Frank Schima)
Changed 8 years ago by 1-61803
comment:2 Changed 8 years ago by 1-61803
I must have missed that part in the guide. Thanks for pointing it out.
comment:3 Changed 8 years ago by mf2k (Frank Schima)
Owner: | set to mf2k |
---|---|
Resolution: | → fixed |
Status: | new → closed |
comment:4 Changed 8 years ago by mf2k (Frank Schima)
Note:
- I added the dependency on ncurses because it was using it.
- I fixed the spacing to conform to the mode line.
comment:5 Changed 8 years ago by 1-61803
readline already depends on ncurses — why is it necessary to add ncurses also in hstr's portfile?
comment:6 Changed 8 years ago by mf2k (Frank Schima)
The rule of thumb is if the port directly depends on it, then the dependency should be added. If ncurses gets an API change, we can easily know which ports will be affected before it gets committed and breaks it!
comment:7 Changed 8 years ago by mf2k (Frank Schima)
For reference:
$ otool -L /opt/local/bin/hstr /opt/local/bin/hstr: /opt/local/lib/libncurses.6.dylib (compatibility version 6.0.0, current version 6.0.0) /opt/local/lib/libreadline.6.dylib (compatibility version 6.0.0, current version 6.3.0) /usr/lib/libSystem.B.dylib (compatibility version 1.0.0, current version 1238.0.0)
Note: See
TracTickets for help on using
tickets.
Change
depends_build
todepends_build-append
anddepends_lib
todepends_lib-append
to not overwrite dependencies pulled in from the GitHub portgroup and by usinguse_autoreconf yes
.