Opened 8 years ago

Closed 7 years ago

Last modified 7 years ago

#53445 closed enhancement (fixed)

port:mlt/mlt-qt5 fixes

Reported by: RJVB (René Bertin) Owned by: ddennedy (Dan Dennedy)
Priority: Normal Milestone:
Component: ports Version:
Keywords: haspatch maintainer Cc: ddennedy (Dan Dennedy), mkae (Marko Käning), raimue (Rainer Müller)
Port: mlt

Description

The attached patch addresses the following issues:

  • qt5.depends_component is now available officially so the local copy can be removed.
  • mlt 6.4.1 doesn't (sufficiently) honour the compiler and build settings that the Portfile passed in via the environment. This is addressed by amending the generated config.mak file.
  • From 5.7.0 onwards Qt5 requires C++11 which at least on 10.9.5 must be requested specifically (with mlt's build system). Doing this requires the previous fix. The C++11 option is added explicitly only when Qt >= 5.7.0 is active but could also be activated unconditionally on platforms that have libc++.

Attachments (4)

mlt.diff (4.1 KB) - added by RJVB (René Bertin) 8 years ago.
mlt.2.diff (5.4 KB) - added by RJVB (René Bertin) 7 years ago.
patch-commit-a3188e3.diff (271 bytes) - added by RJVB (René Bertin) 7 years ago.
patch-no-sdl.diff (512 bytes) - added by RJVB (René Bertin) 7 years ago.

Download all attachments as: .zip

Change History (13)

Changed 8 years ago by RJVB (René Bertin)

Attachment: mlt.diff added

comment:1 Changed 8 years ago by mf2k (Frank Schima)

Keywords: maintainer added

comment:2 Changed 8 years ago by mkae (Marko Käning)

Cc: mkae added

comment:3 Changed 7 years ago by raimue (Rainer Müller)

Owner: set to ddennedy
Status: newassigned

The patch re-introduces the $Id$ line. We are no longer using these.

-version             6.4.1
+version             6.4.1 ; revision 1

The ; should be a newline.

I don't like the idea of introducing new subports that are immediately obsolete. Are you afraid users won't find mlt-qt5?

comment:4 Changed 7 years ago by RJVB (René Bertin)

Mea culpa for the $Id$ line, but I've already said elsewhere that it's completely ridiculous to fuss about syntax details like ; revision N vs. revision N. If anything that's up to the port maintainer to decide. This kind of notation is the best way to avoid forgetting to remove the revision during an actual version upgrade.

As to the obsolete subport: it was introduced for then-current users of the port, I presume that those must all have upgraded to mlt-qt5 by now.

comment:5 Changed 7 years ago by raimue (Rainer Müller)

In my opinion the port syntax should follow the usual conventions. No other port uses such a ; revision N syntax. Of course, from a technical perspective there are lots of ways to achieve the same and this has the same results. Portfiles are written in our own domain specific language, not just anything Tcl allows as valid syntax. Using the same conventions in every Portfile makes it easier for others to read and understand it and enable us to maintain such a large number of ports in the MacPorts ports tree. These rules include indentation with modelines previously agreed upon and adhering to the common order of options.

Changed 7 years ago by RJVB (René Bertin)

Attachment: mlt.2.diff added

Changed 7 years ago by RJVB (René Bertin)

Attachment: patch-commit-a3188e3.diff added

Changed 7 years ago by RJVB (René Bertin)

Attachment: patch-no-sdl.diff added

comment:6 Changed 7 years ago by RJVB (René Bertin)

I actually had a newer version lying around, introducing 2 patches:

  • a cherry-picked upstream patch fixing a crash-on-exit in certain client applications (kdenlive)
  • a variant with patch allowing to build without SDL support, to avoid runtime conflicts with SDL2 (or at least the corresponding warnings).

comment:7 Changed 7 years ago by raimue (Rainer Müller)

Resolution: fixed
Status: assignedclosed

In b8ea59e57d3a0e6fca21b134be4f0e6bd1e3105a/macports-ports:

mlt: Fix crash on startup, avoid SDL dependency

Maintainer update
Closes: #53445

comment:8 Changed 7 years ago by jmroot (Joshua Root)

Cc: raimue added

The mlt-qt5 port fails to parse after this change when you don't have qt5 installed:

% port info mlt-qt5
Error: Unable to open port: Package Qt5Core was not found in the pkg-config search path.
Perhaps you should add the directory containing `Qt5Core.pc'
to the PKG_CONFIG_PATH environment variable
No package 'Qt5Core' found

comment:9 Changed 7 years ago by RJVB (René Bertin)

Doh, the pkg-config invocation has to be wrapped in a catch call, clearly.

Note: See TracTickets for help on using tickets.