Opened 8 years ago

Closed 8 years ago

#53516 closed defect (fixed)

wxWidgets-3.0 fails to build from source with clang-3.9 on snowleopard

Reported by: chrisjogorman Owned by: mojca (Mojca Miklavec)
Priority: Normal Milestone:
Component: ports Version:
Keywords: Cc: jwa@…
Port: wxwidgets-3.0

Description

The attached patch thanks to Boris Pek <tehnick-8@…> allows the build to continue and install. The file to patch is src/stc/scintilla/src/Editor.cxx. I think this should probably be addressed upstream in wxwidgets source, but until they get arround to fixing it, perhaps we should apply it.

Attachments (1)

wxwidgets.diff​ (488 bytes) - added by chrisjogorman 8 years ago.

Download all attachments as: .zip

Change History (4)

Changed 8 years ago by chrisjogorman

Attachment: wxwidgets.diff​ added

comment:1 Changed 8 years ago by mojca (Mojca Miklavec)

Cc: mojca@… removed
Keywords: macports c++-11 wxwidgets removed
Owner: set to mojca
Status: new → assigned
Version: 2.4.0

​Upstream already changed this to std::abs(). Are you able to check whether this works with various compilers on 10.6?

comment:2 Changed 8 years ago by kencu (Ken)

using <cmath> and std::abs() I believe was the proper fix, and that's the one I used a few months ago to build it on SnowLeopard.

comment:3 Changed 8 years ago by mojca (Mojca Miklavec)

Resolution: → fixed
Status: assigned → closed

In dabbaa7a/macports-ports:

wxWidgets-3.0: upstream patch for abs()

This upstream patch fixes a build failure with some newer compilers.

Closes: #53516
See: ​https://github.com/wxWidgets/wxWidgets/pull/222

Note: See TracTickets for help on using tickets.