darkice 1.3 fails to build (error at VorbisLibEncoder.cpp)

[jmalcaide (Jose M. Alcaide)]

Excerpt from /opt/local/var/macports/logs/_opt_local_var_macports_sources_rsync.macports.org_release_tarballs_ports_audio_darkice/darkice/main.log :

:info:build VorbisLibEncoder.cpp:340:9: error: no matching function for call to 'src_short_to_float_array'
:info:build         src_short_to_float_array (shortBuffer, converterData.data_in, totalSamples);
:info:build         ^~~~~~~~~~~~~~~~~~~~~~~~
:info:build /opt/local/include/samplerate.h:171:6: note: candidate function not viable: 2nd argument ('const float *') would lose const qualifier
:info:build void src_short_to_float_array (const short *in, float *out, int len) ;
:info:build      ^
:info:build 1 error generated.
:info:build make[2]: *** [darkice-VorbisLibEncoder.o] Error 1

Dependency libvorbis 1.3.5_0 is installed.

[mf2k (Frank Schima)]

Please attach the complete main.log file.

[nielsd (Niels Dettenbach)]

Replying to mf2k:

Please attach the complete main.log file.

uhh, seem's ugly - possibly rearding changes in libvorbis since port publication. Yes, the complete log would be helpful.

It has build with libvorbis on my machine at the time of port publication - so i assume this regards to libvorbis or the build system. 1.3 is official current stable.

@Frank: If i have to contact the darkice main developer pls just inform me.

[jmalcaide (Jose M. Alcaide)]

I have been looking into this problem, and I think that the darkice port itself has several problems. Basically, it does not honor the default off state of the vorbis variant.

The compiling error affects to the file VorbisLibEncoder.cpp, which is part of the darkice's Ogg Vorbis support. But Ogg Vorbis support should not be added unless vorbis variant has been deliberately turned on. In fact, manually configuring darkice using --without-vorbis option makes the error to go away. Obviously the problem is still there (some incompatibility with libsamplerate), but it should only be triggered when building darkice +vorbis. Also, its dependencies on libvorbis and libsamplerate ports should only be added if the vorbis variant has been turned on. --MY FAULT: both ports are dependencies of the Jack port, not darkice.

I should add that even after installing darkice (specifying --without-vorbis by hand), it didn't work for my intended use, but the culprit was Jack, whose CoreAudio support is buggy. But that's another port.

[neverpanic (Clemens Lang)]

In 473808ef94fd6e093f921e6cb300d23dd490aa05/macports-ports:

darkice: Fix build against modern libsamplerate

Fix a bug in the darkice code by backporting an upstream fix.

Closes: #53761