Opened 8 years ago
Closed 7 years ago
#53971 closed enhancement (fixed)
php-igbinary update to support php7
| Reported by: | chrisminett (Chris Minett) | Owned by: | pixilla (Bradley Giesbrecht) |
|---|---|---|---|
| Priority: | Normal | Milestone: | |
| Component: | ports | Version: | |
| Keywords: | Cc: | ryandesign (Ryan Carsten Schmidt), arkonan (Alexandra Ellwood), jhammer (Jonathan Hammer) | |
| Port: | php-igbinary |
Description
Current version of php-igbinary is 1.2.1, available for php5.x
Latest version is 2.0.3, which supports php5.x and php7.x
By modifying the version number and checksums in the Portfile, it installs and works fine for me (macOS 10.12.4, php 7.1.3) but only by adding new master_sites and distfiles keywords to download from their Github repo. Not sure of the correct behaviour here (can't find anything in the guide), so that an up-to-date distfile can be added.
Change History (9)
comment:1 Changed 8 years ago by mf2k (Frank Schima)
| Cc: | pixilla removed |
|---|---|
| Keywords: | php7 removed |
| Owner: | set to pixilla |
| Status: | new → assigned |
| Type: | update → enhancement |
comment:2 Changed 8 years ago by ryandesign (Ryan Carsten Schmidt)
| Cc: | ryandesign added |
|---|
comment:3 follow-up: 4 Changed 8 years ago by ryandesign (Ryan Carsten Schmidt)
I had started working on this update, but php*-memcached depends on php*-igbinary, and because of the major version number increase, I didn't know whether the new php-igbinary is compatible with the old php-memcached. I wanted to have an update to php-memcached available at the same time. That's #50135 but it needs a new version of libmemcached.
comment:4 Changed 8 years ago by chrisminett (Chris Minett)
Replying to ryandesign:
I had started working on this update, but php*-memcached depends on php*-igbinary, and because of the major version number increase, I didn't know whether the new php-igbinary is compatible with the old php-memcached. I wanted to have an update to php-memcached available at the same time. That's #50135 but it needs a new version of libmemcached.
It might still be possible to do this in stages. Tweaking my igbinary portfile as you suggest, to 2.0.1, successfully downloads and installs from PECL. I can then do a new install of my modified php56-igbinary and the existing php56-memcached, which is using libmemcached 1.0.10, and usage of Memcched in php56 is working fine.
php-memcached release notes at 2.1.0 say they support libmemcached 1.0.x, so there should be no reason for compatibility issues.
igbinary release notes say there are no serialization changes in 2.0.0, and this matches my testing, which involves igbinary-serialized values which I've set and read in igbinary-1.2.1 with php-memcached-2.0.1 (php56), igbinary-2.0.1 with php-memcached-2.0.1 (php56), igbinary-2.0.1 with php-memcached-3.0.3 (php71) ... all using libmemcached-1.0.10
comment:5 Changed 7 years ago by chrisminett (Chris Minett)
Maintainers of igbinary have solved their issue releasing on PECL. Latest version 2.0.4 now available there, so the Portfile could be updated to use that.
comment:6 Changed 7 years ago by arkonan (Alexandra Ellwood)
| Cc: | arkonan added |
|---|
comment:7 Changed 7 years ago by jhammer (Jonathan Hammer)
| Cc: | jhammer added |
|---|
comment:8 Changed 7 years ago by chrisminett (Chris Minett)
comment:9 Changed 7 years ago by ryandesign (Ryan Carsten Schmidt)
| Resolution: | → fixed |
|---|---|
| Status: | assigned → closed |
The correct procedure for using GitHub-hosted files is to use the github 1.0 portgroup. However, the even more correct procedure for this port is for the developers of igbinary to release their software on PECL; they are tracking this problem here: https://github.com/igbinary/igbinary/issues/122
The latest version on PECL is 2.0.1; we could update to that.