highlight @3.36 fails to build with libc++

[1-61803]

It also fails with 3.28 and 3.35. According to #53719, 3.35 builds on 10.6 and there's also a workaround posted for 3.36 on 10.7 that I haven't tried yet on 10.8.

[ryandesign (Ryan Carsten Schmidt)]

Yes, this is another case of a build system that does not understand that it needs to use CXXFLAGS at link time as well when linking C++ code. The workaround posted in #53719 should be sufficient until the port or the build system is fixed.

[1-61803]

I confirm sudo port install highlight configure.cxxflags="-stdlib=libc++" configure.cxx="clang++ -stdlib=libc++" builds 3.36 on 10.8.

[1-61803]

Thanks to Ken Cunningham for the guidance, see ​this post and related thread.

On 10.8 I had 3 possibilities:

1. run this command, see also ticket:53719#comment:12.

   sudo port install highlight configure.cxxflags="-stdlib=libc++" configure.cxx="clang++ -stdlib=libc++"
   

2. patch the portfile with the flags in 1.

3. install a newer compiler and change runtime.

I did the latter: installed clang-3.9 and set libc++.

1. modify /opt/local/etc/macports/macports.conf (see ​here).

   default_compilers  macports-clang-3.9
   cxx_stdlib         libc++
   buildfromsource    always
   delete_la_files    yes
   

2. patch the compiler to use libc++ in <10.9.

· check out ​bb3b700f76 from macports-ports (clang-3.9 @3.9.0_2) and patch it manually, or

· use the files from ​Ken's GitHub repo

Basically, in the portfile add

# patch clang to always default to -stdlib=libc++, even on <10.9
patchfiles-append 999-patch-clang-3.9-Toolchains-default-always-libcxx.diff

and in the patchfile

--- ./tools/Clang/lib/Driver/ToolChains.cpp.orig	2016-12-21 00:45:00.000000000 -0800
+++ ./tools/Clang/lib/Driver/ToolChains.cpp	2016-12-21 00:45:42.000000000 -0800
@@ -73,7 +73,7 @@
        isTargetWatchOSBased())
     return ToolChain::CST_Libcxx;
 
-  return ToolChain::CST_Libstdcxx;
+  return ToolChain::CST_Libcxx;
 }

[kencu (Ken)]

In 1aee29e12f6c9ee099f1fd194df8623daa9b5108/macports-ports:

highlight: update to 3.39

change to cxx11 1.1 portgroup
add -stdlib to clang builds
fixes: #53994
fixes: #53719