Opened 8 years ago

Closed 8 years ago

#54066 closed defect (fixed)

qt56 @5.6.2 fails to build

Reported by: 1-61803 Owned by: MarcusCalhoun-Lopez (Marcus Calhoun-Lopez)
Priority: Normal Milestone:
Component: ports Version:
Keywords: Cc:
Port: qt56

Description

On OS X 10.8.5, building from source, libc++, Xcode 5.1.1, up-to-date CLT. I dont't know if #53949 and #52922 are related.

Attachments (1)

qt5-qtmultimedia_failed_main.log (923.0 KB) - added by 1-61803 8 years ago.

Download all attachments as: .zip

Change History (7)

Changed 8 years ago by 1-61803

comment:1 Changed 8 years ago by ryandesign (Ryan Carsten Schmidt)

Cc: MarcusCalhoun-Lopez removed
Owner: set to MarcusCalhoun-Lopez
Status: newassigned

The log says:

:info:build avfcamerautility.mm:549:92: error: property 'firstObject' not found on object of type 'NSArray *'

which is weird because firstObject was added in the 10.6 SDK, and the log shows the 10.8 SDK is being used.

comment:2 Changed 8 years ago by 1-61803

12 is the only version missing http://packages.macports.org/qt56-qtmultimedia/.

comment:3 Changed 8 years ago by kencu (Ken)

Try including this patch, which appears to be left out on 12.

https://github.com/macports/macports-ports/commit/ec39a5a3336f1aea6aa0755286c202c3814fe72b

Change 12 to 13 in the port file vercmp test.

Last edited 8 years ago by kencu (Ken) (previous) (diff)

comment:4 Changed 8 years ago by kencu (Ken)

btw, the patch is already sitting there in the qt56 files directory. you just have to edit the portfile to change 12 to 13 down near the bottom 1/3 of the file, to force it to include the patch. And it looks like the test block has changed a bit in the qt56 Portfile from that original commit above.

Change this:

            # special case
            if { ${module} eq "qtmultimedia" } {
                if { ${os.major} < 12 } {
                    # see https://trac.macports.org/ticket/52922
                    patchfiles-append patch-firstObject.diff
                }
            }

to this:

            # special case
            if { ${module} eq "qtmultimedia" } {
                if { ${os.major} < 13 } {
                    # see https://trac.macports.org/ticket/52922
                    patchfiles-append patch-firstObject.diff
                }
            }

comment:5 in reply to:  3 Changed 8 years ago by 1-61803

Replying to kencu:

Change 12 to 13 in the port file vercmp test.

You beat me to it. Thanks! It builds fine now.

An aside re #53949: qt5 @5.7.1 is not being built for 10.8 http://packages.macports.org/qt5/ and has not patch for firstObject either.

comment:6 Changed 8 years ago by MarcusCalhoun-Lopez (Marcus Calhoun-Lopez)

Resolution: fixed
Status: assignedclosed

In 5c1ed536cadfa66a1c197fc1ccd7635e050712a9/macports-ports:

qt5*-qtmultimedia: apply patchfile to OS X 10.8

Qt uses firstObject in NSArray's interface.

Fixes #53949
Fixes #54066

Note: See TracTickets for help on using tickets.