mpbb: unrecognized option `--archive-site' Try `./mpbb/mpbb help' for more information.

[ryandesign (Ryan Carsten Schmidt)]

I updated the buildmaster to the latest version of master.cfg. Builds now don't run because listing subports fails because:

./mpbb/mpbb: unrecognized option `--archive-site'
Try `./mpbb/mpbb help' for more information.

It looks like mpbb should understand this.

[ryandesign (Ryan Carsten Schmidt)]

Buildbot is running e.g.:

./mpbb/mpbb --prefix /opt/local --archive-site https://packages.macports.org list-subports ncarg

But mpbb (specifically parseopt I guess) only understands it if we run --archive-site=https://packages.macports.org.

Using the = sign makes more sense to me, but all options should use the same syntax...

[ryandesign (Ryan Carsten Schmidt)]

Replying to ryandesign:

But mpbb (specifically parseopt I guess) only understands it if we run --archive-site=https://packages.macports.org.

On second thought, that's not it; parseopt uses getopt(1) which claims to support either form.

I think the problem is that the parseopt call was added to print-subports but needs to be added instead to list-subports. Not sure the best way to then pass the result to print-subports where it's needed.

[neverpanic (Clemens Lang)]

Here's my ad-hoc analysis from IRC, hoping that it helps. Don't have time to make the change right now, though.

• mpbb is invoked as ./mpbb --archive-site foobar list-subports "portname"
• That hands over control flow to mpbb-list-subports in ​https://github.com/macports/mpbb/blob/master/mpbb#L116, passing all options using "$@"
• list-subports() in mpbb-list-subports runs for port in "$@"; do print-subports "$port"; done, see ​https://github.com/macports/mpbb/blob/master/mpbb-list-subports#L109
• And print-subports() runs parseopt archive-site: "$@", which tries to find --archive-site in "$@" of that function, but that function only gets "portname" as argument, which does not contain --archive-site, obviously
• So ​https://github.com/macports/mpbb/commit/5c7ba12259a066a90a3e2ca2e4b09c9bac4aeb7b is buggy, the parseopt archive-site: "$@" || return should have been in list-subports()
• Additionally, I think ​https://github.com/macports/macports-infrastructure/commit/f79cc559611e5f42dd26808f38cd0750beee12bf should have added the --archive-site flag after list-subports, not before.

[neverpanic (Clemens Lang)]

Cc jmroot, who implemented this.

[ryandesign (Ryan Carsten Schmidt)]

Yes those were the conclusions I reached as well.

[ryandesign (Ryan Carsten Schmidt)]

I reverted to the previous master.cfg for now and re-ran the failed builds.

[jmroot (Joshua Root)]

[62daca49/macports-infrastructure]

[ryandesign (Ryan Carsten Schmidt)]

Replying to jmroot:

[62daca49/macports-infrastructure]

Is that the only change we need? What about:

Replying to neverpanic:

• So ​https://github.com/macports/mpbb/commit/5c7ba12259a066a90a3e2ca2e4b09c9bac4aeb7b is buggy, the parseopt archive-site: "$@" || return should have been in list-subports()

[jmroot (Joshua Root)]

Also [3b661223/mpbb].